-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed --parseable-severity feature #1898
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the unorthodox CLI option and output format as we have other standard file output formats that also include the same information and they are considerably more flexible. Fixes: ansible#1732
ssbarnea
requested review from
relrod,
priyamsahoo and
webknjaz
and removed request for
a team
February 14, 2022 16:28
cognifloyd
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm indifferent here.
cidrblock
approved these changes
Feb 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
AKorezin
added a commit
to AKorezin/ansible-lint-junit
that referenced
this pull request
Sep 1, 2022
Reformat beginning and move badges before the initial header like in the ansible-lint project. Remove outdated ansible-lint call with --parseable-severity, because it was removed in ansible/ansible-lint#1898. Reformat list of available calls to make look like there are several methods of calling ansible-lint-junit, not a list of consecutive actions. Add information about project license. Fix grammar and style.
AKorezin
added a commit
to AKorezin/ansible-lint-junit
that referenced
this pull request
Sep 1, 2022
Reformat beginning and move badges before the initial header like in the ansible-lint project. Remove outdated ansible-lint call with --parseable-severity, because it was removed in ansible/ansible-lint#1898. Reformat list of available calls to make look like there are several methods of calling ansible-lint-junit, not a list of consecutive actions. Add information about project license. Fix grammar and style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the unorthodox CLI option and output format as we have other standard file output formats that also include the same information and they are considerably more flexible.
This will simplify both the implementation and also the list of command line arguments the tool accepts. This will be followed up by another change that will also remove the
-p
argument as that was kept as alias for-f pep8
for long time.Fixes: #1732