Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent parseable option from changing JSON output format #1730

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Conversation

ssbarnea
Copy link
Member

This bug was originally reported against ansible-language-server but
it proved to be caused by a bug inside the linter.

Fixes: ansible/ansible-language-server#43

This bug was originally reported against ansible-language-server but
it proved to be caused by a bug inside the linter.

Fixes: ansible/ansible-language-server#43
@ssbarnea ssbarnea changed the title Avoid altering format when parseable option is configured Prevent parseable option from changing JSON output format Sep 30, 2021
Copy link
Contributor

@tadeboro tadeboro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will fix the immediate issue at hand, but the process of selecting the output format is a mess. As far as I can tell, there are at least three command-line flags that affect the output: -p, -f, and --parseable-severity. And there is not information on how should those things interact.

@ssbarnea
Copy link
Member Author

ssbarnea commented Oct 1, 2021

This change will fix the immediate issue at hand, but the process of selecting the output format is a mess. As far as I can tell, there are at least three command-line flags that affect the output: -p, -f, and --parseable-severity. And there is not information on how should those things interact.

@tadeboro I totally agree with you on that aspect. I am aware of it and I want to remove both parseable and severity options, keeping only format w/o any modifiers but this would require a major version bump. Part of the same change is renaming "codeclimate" to "json", while keeping the format the same (likely with an alias). I do remember 2-3 feature request for json output added after we implemented it.

@ssbarnea ssbarnea merged commit ef02119 into main Oct 1, 2021
@ssbarnea ssbarnea deleted the fix/core branch October 1, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not parse ansible-lint output when parseable output mode enabled
3 participants