Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all steering committee members have appropriate rights to this repository #1020

Closed
samccann opened this issue Jan 5, 2024 · 23 comments

Comments

@samccann
Copy link
Contributor

samccann commented Jan 5, 2024

The Ansible community Steering Committee controls and approves all changes to a subset of contributor documentation as well as the general SC guidelines, membership, and community package inclusion/removal processes.

In order to support the workflow for steering committee members to control these documents, we need to have all SC members added to https://github.com/orgs/ansible/teams/steering-committee

See ansible-community/community-topics#243 (comment) for details.

@ansible-documentation-bot ansible-documentation-bot bot added the needs_triage Needs a first human triage before being processed. label Jan 5, 2024
@samccann
Copy link
Contributor Author

samccann commented Jan 5, 2024

The names we need to add are:

  • Alexei Znamensky - russoz
  • Brian Scholer - briantist
  • Mario Lenz - mariolenz
  • Markus Bergholz - markuman
  • James Cassell - jamescassell

@Andersson007
Copy link
Contributor

@samccann any estimates? It's a blocker for a few approved PRs to get merged, no rush though

@samccann
Copy link
Contributor Author

I've poked the folks who can make this happen and it's under discussion. Keep reminding me tho!

@gotmax23
Copy link
Collaborator

@samccann, any updates here? Is there a specific issue that's blocking this?

@samccann
Copy link
Contributor Author

Let me nag again.

@samccann
Copy link
Contributor Author

Ok I'm being asked why we need the SC team at the Ansible org level. The suggestion is to have the SC members just in this repo, not at the higher level ansible org level.

Is this just a case of creating a similar team here and add all the members (then change whatever was using the old org-level team with this new repo-level team?

@thedoubl3j
Copy link
Member

@samccann teams are org level if I recall, so my guess is that the users would be added as outside collaborators to this repo. Does SC need access to other repositories at the admin/maintainer level?

@samccann
Copy link
Contributor Author

Also found out adding members at the org level costs $$. So let's see if we can find a repo-local solution.

@samccann
Copy link
Contributor Author

Okay so we can add individuals to this repo with maintain rights, which is what I think the SC members need, but we can't add more people to the existing steering_committee team because as @thedoubl3j said, teams are only at the org level.

@gotmax23 I think this means we'd have to list each SC member separately in the CODEOWNERS file, as well as anyplace else that uses the steering_committee team today, right?

@samccann
Copy link
Contributor Author

Just to clarify a bit - the Ansible org has kept its list of members tightly controlled for a number of years, and regularly removes members to keep down the cost. This isn't anything specific to the SC folks (or docs).

@gotmax23
Copy link
Collaborator

I'd really like for the steering-committee team in the ansible org to include all the steering committee members. We use it for CODEOWNERS, requesting reviews, and other organizational purposes, and ideally, it could stay that way.

@samccann
Copy link
Contributor Author

At this point, we aren't able to add the other steering committee members so we need to investigate the alternatives. Back in the dim dawn of time (aka when we were discussing this docs repo) the original request was to have it in ansible-community org (which we do have community control over).

Does anyone recall why we didn't move docs to there?

@samccann samccann removed the needs_triage Needs a first human triage before being processed. label Feb 22, 2024
@samccann
Copy link
Contributor Author

discussion on moving just community guides to another repo - https://forum.ansible.com/t/should-we-move-community-guides-to-their-own-docsite-and-repo/4006

@samccann
Copy link
Contributor Author

Decision is to not move any content around just yet. So we have to manually update SC membership where needed and stop using the steering-committee group as we can't add all SC members to it.

@gotmax23
Copy link
Collaborator

Would it be possible to at least add @mariolenz to the SC group or as an outside contributor? He has done a lot of docs-related work for the steering committee with updating release schedules and such.

@samccann
Copy link
Contributor Author

At this point I can't add anyone. I think our best way forward is to manually manage the list of names.

@mariolenz
Copy link
Contributor

@gotmax23 @samccann I can live with not being added if it's not really possible. After all, I can comment on issues and PRs and open new news. So there's no real problem for me ;-)

@samccann
Copy link
Contributor Author

:-) Kind of you. But there are other issues pending on resolving this. I can't find them off the top of my head, but the idea of moving all the collection process docs into the official docs here is on hold until all the SC folks have maintainer rights in this repo.

@samccann
Copy link
Contributor Author

Discussed in DaWGs and we will manually maintain the list of SC members 'where needed' and stop using the group here in the Ansible repo since we can't add new members to the org.

@gotmax23
Copy link
Collaborator

I'm coming around to moving this to the ansible-community organization if the Ansible core maintainers who contribute to this repository as well are also open to it and there aren't any other significant benefits to staying in the @ansible organization that I'm missing. Being able to use the existing @ansible-community teams is nice from an autonmation/repo management perspective.

@samccann
Copy link
Contributor Author

@samccann
Copy link
Contributor Author

Based on https://forum.ansible.com/t/should-we-move-the-ansible-documentation-repo-to-ansible-community-org/5224/10 we cannot move the repo at this point. Splitting out core-docs is a longer-term consideration, so at this point we must manually update the SC members where needed.

Are there other places this needs to change?

@samccann
Copy link
Contributor Author

AAAND... changing this again - based on initial core discussion, we will be thinking about how we can split the docs. Going to close this in favor of #1538 (which will discuss how we ...split the docs and move community/package/SC docs to a different repo)>

@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in Ansible Documentation May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

5 participants