Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defined var for timeout not used #132

Closed
ipruteanu-sie opened this issue Dec 5, 2023 · 1 comment
Closed

Defined var for timeout not used #132

ipruteanu-sie opened this issue Dec 5, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ipruteanu-sie
Copy link
Contributor

Describe the Issue
In defaults/main.yml file, there's this default definition:

audit_cmd_timeout: 120000

However, this is not used. Is this the intended way ?

Expected Behavior
A reference should be made towards audit_cmd_timeout variable, most probably in ansible_vars_goss.yml.j2 file:

timeout_ms: {{ audit_cmd_timeout }}
# instead of
# timeout_ms: 60000

Actual Behavior
ansible_vars_goss.yml.j2 file contains a new value, making the default value never used:

timeout_ms: 60000

Control(s) Affected
N/A, Goss

Environment (please complete the following information):

  • branch being used: [e.g. devel]
    Possible Solution
    Added a PR.
@uk-bolly
Copy link
Member

hi @ipruteanu-sie

This Issue has been merged to devel and into main branch. I will therefore close this issue.
Please feel free to reopen if you feel its not as expected.

Many thanks again for your time

uk-bolly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants