Skip to content

Commit

Permalink
nox: remove formatters session
Browse files Browse the repository at this point in the history
  • Loading branch information
gotmax23 committed Mar 24, 2023
1 parent f686012 commit df0db32
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 22 deletions.
9 changes: 4 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,10 @@ You can change this behavior through the `OTHER_ANTSIBULL_MODE` env var:
To run specific tests:

1. `nox -e test` to only run unit tests;
2. `nox -e lint` to run all linters and formatters at once;
3. `nox -e formatters` to run `isort`;
4. `nox -e codeqa` to run `flake8`, `pylint`, and `reuse lint`;
5. `nox -e typing` to run `mypy` and `pyre`.
6. `nox -e coverage_release` to build a test ansible release.
2. `nox -e lint` to run all linters;
3. `nox -e codeqa` to run `flake8`, `pylint`, and `reuse lint`;
4. `nox -e typing` to run `mypy` and `pyre`.
5. `nox -e coverage_release` to build a test ansible release.
This is expensive, so it's not run by default.

To create a more complete local development env:
Expand Down
14 changes: 0 additions & 14 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@
"1",
"true",
)
LINT_CHECK_MODE = os.environ.get("LINT_CHECK_MODE", str(IN_CI)).lower() in (
"1",
"true",
)

# Always install latest pip version
os.environ["VIRTUALENV_DOWNLOAD"] = "1"
Expand Down Expand Up @@ -128,20 +124,10 @@ def coverage_release(session: nox.Session):

@nox.session
def lint(session: nox.Session):
session.notify("formatters")
session.notify("codeqa")
session.notify("typing")


@nox.session
def formatters(session: nox.Session):
install(session, ".[formatters]", editable=True)
posargs = list(session.posargs)
if LINT_CHECK_MODE:
posargs.append("--check")
session.run("isort", *posargs, "src", "tests", "noxfile.py")


@nox.session
def codeqa(session: nox.Session):
install(session, ".[codeqa]", *other_antsibull(), editable=True)
Expand Down
3 changes: 0 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,6 @@ codeqa = [
"pylint",
"reuse",
]
formatters = [
"isort",
]
dev = [
# Used by nox sessions
"antsibull[codeqa]",
Expand Down

0 comments on commit df0db32

Please sign in to comment.