Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: allow running release workflow from an existing branch #391

Closed
gotmax23 opened this issue Apr 24, 2024 · 4 comments · Fixed by #404
Closed

ci: allow running release workflow from an existing branch #391

gotmax23 opened this issue Apr 24, 2024 · 4 comments · Fixed by #404

Comments

@gotmax23
Copy link
Contributor

This way, the release manager could commit other changes prior to running the release GHA while still having those changes included in the PR.

@felixfontein
Copy link
Contributor

We might have to change antsibull as well so it only adds the release summary in case it isn't there already. Right now the prepare step always overwrites the release summary. (Which is the reason I'm doing 9.5.1 manually.)

@felixfontein
Copy link
Contributor

Changes needed for antsibull:

  • Do not clobber release summary and date when they're already present (or at least make that configurable);
  • Allow to skip prepare step (Prepare a release with new dependencies) in the release role - this is needed for 10.0.0, which should have the exact same requirements as the last release candidate. Can also be needed in other cases.
  • Set up feature freeze for b2 through rc1 should be extended to more betas and also more release candidates (though likely for rc2 and later RCs you want to use the feature from the previous bullet point, to explicitly force specific versions).

@felixfontein
Copy link
Contributor

I created PRs for the antsibull features: ansible-community/antsibull-build#597, ansible-community/antsibull-build#598

@felixfontein
Copy link
Contributor

#405 demonstrated that this now works 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants