Bugfix/769/mode option does not behave the same way that it does in the community module

[AndreMarcel99]

SUMMARY

Add files that are found in the destination that are coming from a previous copy of same dest to the change permissions loop by add to array of list of files to change mode.

Fixes #769

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

A line of code that add everything that is inside the target folder that also is found in origin folder to the array to change mode.

ADDITIONAL INFORMATION

Also change names of variables in the function _get_changed_files to make easy to read and clear the description with present names not names in past because the information haven't been transform in the function.
Change 3 test cases to ensure the overwrite also works on mode if is send.

Playbook to test:

tasks:
 - name: Copy files to non existing directory.
   zos_copy:
     src: ./tests/
     dest: /tests/

 - name: Get permissions.
   ansible.builtin.command:
     cmd: "ls -la /tests/"
   register: Output
 - name: Response 
   debug:
     msg: "{{ Output }}"

 - name: Overwrite files with different permissions.
   zos_copy:
     src: ./tests/
     dest: /tests/
     force: true
     mode: "777"

 - name: Get permissions.
   ansible.builtin.command:
     cmd: "ls -la /tests/"
   register: Output
 - name: Response 
   debug:
     msg: "{{ Output }}"

Output:

PLAY [zvm] *********************************************************************************************************************************************************************

TASK [Copy files to non existing directory.] ***********************************************************************************************************************************

changed: [zvm]

TASK [Get permissions.] ********************************************************************************************************************************************************

changed: [zvm]

TASK [Response] ****************************************************************************************************************************************************************

ok: [zvm] => {
    "msg": {
        "changed": true,
        "cmd": [
            "ls",
            "-la",
            "/tests/"
        ],
        "delta": "0:00:15.042574",
        "end": "2023-06-02 23:10:51.225764",
        "failed": false,
        "rc": 0,
        "start": "2023-06-02 23:10:36.183190",
        "stderr": "",
        "stderr_lines": [],
        "stdout": "total 32\ndrwxr-xr-x   2 BPXROOT  SYS1        8192 Jun  2 23:07 .\ndrwxr-xr-x  18 BPXROOT  SYS1        8192 Jun  2 23:08 ..\n-rw-r--r--   1 BPXROOT  SYS1           0 Jun  2 23:07 my.jcl",
        "stdout_lines": [
            "total 32",
            "drwxr-xr-x   2 BPXROOT  SYS1        8192 Jun  2 23:07 .",
            "drwxr-xr-x  18 BPXROOT  SYS1        8192 Jun  2 23:08 ..",
            "-rw-r--r--   1 BPXROOT  SYS1           0 Jun  2 23:07 my.jcl"
        ]
    }
}

TASK [Overwrite files with different permissions.] *****************************************************************************************************************************

changed: [zvm]

TASK [Get permissions.] ********************************************************************************************************************************************************

changed: [zvm]

TASK [Response] ****************************************************************************************************************************************************************

ok: [zvm] => {
    "msg": {
        "changed": true,
        "cmd": [
            "ls",
            "-la",
            "/tests/"
        ],
        "delta": "0:00:24.939784",
        "end": "2023-06-02 23:16:03.241356",
        "failed": false,
        "rc": 0,
        "start": "2023-06-02 23:15:38.301572",
        "stderr": "",
        "stderr_lines": [],
        "stdout": "total 32\ndrwxr-xr-x   2 BPXROOT  SYS1        8192 Jun  2 23:14 .\ndrwxr-xr-x  18 BPXROOT  SYS1        8192 Jun  2 23:08 ..\n-rwxrwxrwx   1 BPXROOT  SYS1           0 Jun  2 23:14 my.jcl",
        "stdout_lines": [
            "total 32",
            "drwxr-xr-x   2 BPXROOT  SYS1        8192 Jun  2 23:14 .",
            "drwxr-xr-x  18 BPXROOT  SYS1        8192 Jun  2 23:08 ..",
            "-rwxrwxrwx   1 BPXROOT  SYS1           0 Jun  2 23:14 my.jcl"
        ]
    }
}

[fernandofloresg]

looks good to me

[ddimatos]

@richp405 I added you because you looked at #790 and it should be the same.
@AndreMarcel99 , I should have probably informed you and its my shortcoming that during the release process we merge the GA upstream branch (1.6.0) into down stream (1.7.0-beta.1 - dev) hence we could probably have avoided doing this work and simply had it automerge from 1.6.

[richp405]

Looks good to me

[ddimatos]

Thanks everyone, ill merge it.