Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/1.3.4 gh issue329 ddname #334

Merged
merged 26 commits into from
Jun 11, 2022
Merged

Conversation

fernandofloresg
Copy link
Collaborator

SUMMARY

Fixed a typo in module_utils/job.py:
module_utils/job.py line 59 in 1.3.4 code reads:
dd_name = parsed_args.get("ddname") or ""

To
dd_name = parsed_args.get("dd_name") or ""
Fixes #329 on support 1.3.x branch

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module_utils/job.py
tests/functional/modules/test_zos_job_output_func.py

ADDITIONAL INFORMATION

samdoran and others added 26 commits May 31, 2022 21:11
There was a bug in Ansible that would result in task retries
overriding the connection retries. Using a different name for the
connection retries setting avoids this issue on versions of
Ansible that are missing the bug fix.
Resolves the usage of a non-existent constant that looks to
have been removed around ansible-core 2.4. Adds logic to
support users currently on ansible-core 2.9 and later. This
issue relates to upstream community changes:

 -  task_executor: use correct value for ssh connection retries

Pull request #75155
Signed-off-by: ddimatos <[email protected]>
…line emphasis start-string without end-string.

Signed-off-by: ddimatos <[email protected]>
…failing sanity tests so restoring

Signed-off-by: ddimatos <[email protected]>
Copy link
Collaborator

@ddimatos ddimatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the added test case.

@ddimatos ddimatos merged commit 7026cbc into support/1.3.x Jun 11, 2022
@ddimatos ddimatos deleted the bugfix/1.3.4-GHIssue329-ddname branch June 11, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants