-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/1.3.4 gh issue329 ddname #334
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug in Ansible that would result in task retries overriding the connection retries. Using a different name for the connection retries setting avoids this issue on versions of Ansible that are missing the bug fix.
Resolves the usage of a non-existent constant that looks to have been removed around ansible-core 2.4. Adds logic to support users currently on ansible-core 2.9 and later. This issue relates to upstream community changes: - task_executor: use correct value for ssh connection retries Pull request #75155 Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
…line emphasis start-string without end-string. Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
…failing sanity tests so restoring Signed-off-by: ddimatos <[email protected]>
…re going to pass Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
…s/ibm_zos_core into bugfix/1.3.4-GHIssue329-ddname
ddimatos
approved these changes
Jun 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the added test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixed a typo in module_utils/job.py:
module_utils/job.py line 59 in 1.3.4 code reads:
dd_name = parsed_args.get("ddname") or ""
To
dd_name = parsed_args.get("dd_name") or ""
Fixes #329 on support 1.3.x branch
ISSUE TYPE
COMPONENT NAME
module_utils/job.py
tests/functional/modules/test_zos_job_output_func.py
ADDITIONAL INFORMATION