Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.8.0] [Backport] [zos_copy] mvs to non existent mvs copy verify destination attrs match #1067

Conversation

AndreMarcel99
Copy link
Collaborator

@AndreMarcel99 AndreMarcel99 commented Nov 23, 2023

SUMMARY

The copy of an executable and aliases in a dataset to a creation to another dataset not in existence modify size.

Fixes #1022

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

Remove the function of ensure_present and modify the function of allocate model data set to include the correct one for executables.

ADDITIONAL INFORMATION

Remove the ensure_present function by calculating the size and now using function of allocate_model_data_set to include a case about executable using:
if executable: alloc_cmd = """{0} - RECFM(U) - DSNTYPE(LIBRARY)""".format(alloc_cmd)
Pipeline

@AndreMarcel99 AndreMarcel99 marked this pull request as ready for review November 23, 2023 22:11
Copy link
Collaborator

@fernandofloresg fernandofloresg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, same as the merge to dev, please from now on test with python 3.10+

@fernandofloresg fernandofloresg changed the title backport mvs to non existent mvs copy verify destination attrs match [v1.8.0] [Backport] [zos_copy] mvs to non existent mvs copy verify destination attrs match Nov 24, 2023
Copy link
Collaborator

@richp405 richp405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay here.

…o_non_existent_MVS_copy-verify_destination_attrs_match_up
Copy link
Collaborator

@ddimatos ddimatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice catch with the alloc cmd @AndreMarcel99

@ddimatos ddimatos merged commit 47d3b8a into staging-v1.8.0 Nov 27, 2023
@AndreMarcel99 AndreMarcel99 deleted the staging-v1_dot_8/bugfix/1022/MVS_to_non_existent_MVS_copy-verify_destination_attrs_match_up branch November 30, 2023 15:36
fernandofloresg added a commit that referenced this pull request Dec 13, 2023
* [v1.8.0][Backport] Clean temporary data sets created during XMIT unarchive operation (#1054)

* Clean temporary data sets created during XMIT unarchive operation (#1049)

* Added a temp cleanup

* Added changelog

* Modified changelog

* Added removal of src if remote_src is False

Signed-off-by: Fernando Flores <[email protected]>

* Modified changelog fragments

---------

Signed-off-by: Fernando Flores <[email protected]>

* Update 1049-xmit-temporary-data-sets.yml

modified PR number

---------

Signed-off-by: Fernando Flores <[email protected]>

* Cherry picked v1.8.0 (#1063)

* Bug 1041 zos submit job honor return output literally (#1058)

* initial commit to pass return_output to job_output.

* corrected fragment name to match branch

* tweaked data set test to show result values if positive test fails

* removed trace in zos_data_set, and added trace output to job_submit

* removed extra text from functional testing.

* put in correct PR number in changelog fragment.

* changed trivial to minor_changes, added documentation to dd_scan in job:job_output.

* 1043 bug title zos operator is passing wrong value to zoauopercmd (#1044)

* corrected kwarg index value from 'wait_arg' to 'wait'
Also corrected true/false issue in zoaq

* Added and updated changelog.

* update PR number in changelog fragment

* changed test from \$ to \\$ to eliminate warning

* added blocking test to maks sure minimum wait is reached in zoau>1.2.4.5

* removed the else condition from the blocking test, since it is not needed.

* corrected tense grammer in changelog fragment

* corrected capitalization of ZOAU in changelog fragment.

* updated changelog to point to the backport PR

* [v1.8.0] [Backport] [zos_script] remote_tmp for zos_script (#1068)

* Enabler/1024/remote_tmp for zos_script (#1060)

* Changed tmp_path for Ansible's remote_tmp

* Remove tmp_path from module's options

* Update module documentation

* Remove tmp_path test case

* Update zos_script's RST file

* Add changelog fragment

* Updated module examples

* Update changelog fragment

* [v1.8.0][zos_job_submit] Removes tmp files left behind by zos_job_submit (#1070)

* Ensure proper cleanup for ansiballz

* Added proper removal of AnsiballZ

* [v1.8.0][zos_copy][backport] File wrongly modified after second copy (#1069)

* [zos_copy] Files corrupted after second copy (#1064)

* Initial change to replace shutil.copy

* Added fix for corrupted directory copies

* Added changelog fragment

* Modified docstring and fixed copy_tree

* Added punctiation

* Added copystat

* Added set mode for dirs

* Update 1064-corruped-second-copy.yml

* Updated changelog

* [v1.8.0] [backport] [Documentation] [zos_tso_command] Add REXX exec example (#1072)

* [Documentation] [zos_tso_command] Add REXX exec example (#1065)

* Add REXX exec example

* Add fragment

* Update module documentation

* Fix PR link

* Reword example task name

* Updated REXX example

* Update changelog fragment

* Update RST file

---------

Co-authored-by: Fernando Flores <[email protected]>

* [v1.8.0] [Backport] [zos_copy] mvs to non existent mvs copy verify destination attrs match (#1067)

* Add changes

* Add fragment

* Modify fragment

* Modify fragment

* [zos_copy] fix for executables copied from local fail with iconv error (#1079)

* Added fix for executables copied from local and test

* Added changelog

* update link in managed_node doc (#1089)

* update link in managed_node doc

Signed-off-by: Ketan Kelkar <[email protected]>

* Updated docs regarding managed node

Signed-off-by: ddimatos <[email protected]>

* Doc fragment

Signed-off-by: ddimatos <[email protected]>

---------

Signed-off-by: Ketan Kelkar <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Co-authored-by: ddimatos <[email protected]>

* Merge staging-v1.8.0-tasks into staging-v1.8.0 (#1090)

* Modified galaxy version

* mofidied meta

* Update copyright year

* Generated module docs

* Created changelog

* Removed changelog fragments

* Updated changelog and release notes

* Fixed newline sequences

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Corrected release notes

---------

Signed-off-by: Fernando Flores <[email protected]>
Signed-off-by: Ketan Kelkar <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Co-authored-by: Rich Parker <[email protected]>
Co-authored-by: Ivan Moreno <[email protected]>
Co-authored-by: André Marcel Gutiérrez Benítez <[email protected]>
Co-authored-by: ketankelkar <[email protected]>
Co-authored-by: ddimatos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants