Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [zos_blockinfile] Can quotes in content can be supported #417

Closed
ddimatos opened this issue Sep 15, 2022 · 1 comment
Closed

[Bug] [zos_blockinfile] Can quotes in content can be supported #417

ddimatos opened this issue Sep 15, 2022 · 1 comment
Assignees
Labels
Bug Something isn't working as designed. In Plan Issue has been accepted put into a planned release

Comments

@ddimatos
Copy link
Collaborator

ddimatos commented Sep 15, 2022

SUMMARY

This is a research item to identify the cases we might be missing.
Today in zos_blockinfle we support no quotes in the content block, in fact if we see them we strip them out (issue #303).

In discussion it came up that possibly this might need to be supported:

- name: Update USS script
      zos_blockinfile:
        src: "/u/scripts/script.sh"
        insertafter: "EOF"
        block: |
             cat "//'{{ DS_NAME }}'"
             cat "//'{{ DS_NAME_2 }}'"
      register: result
    - name: Response
      debug:
        msg: "{{ result }}"

This could also easily apply to a data set of type PDS/E where a member might have content like wanting to append some cat statements.

//BPXSLEEP JOB MSGCLASS=A,MSGLEVEL=(1,1),NOTIFY=&SYSUID,REGION=0M
//USSCMD EXEC PGM=BPXBATCH
//STDERR  DD SYSOUT=*
//STDOUT  DD SYSOUT=*
//STDPARM DD *
SH ls -la /;
sleep 30;
/*
// 

This could possibly impact ZOAU dmod dependency depending on the research.
Review applicable ZOAU JIRA 9120

@ddimatos ddimatos added Bug Something isn't working as designed. Enhancement Enhancement to existing collection content and removed Bug Something isn't working as designed. labels Sep 15, 2022
@ddimatos ddimatos changed the title [Research] [zos_blockinfile] Investigate it quotes in content can be supported [Research] [zos_blockinfile] Investigate if quotes in content can be supported Sep 23, 2022
@ddimatos ddimatos changed the title [Research] [zos_blockinfile] Investigate if quotes in content can be supported [Task] [zos_blockinfile] Investigate if quotes in content can be supported Sep 23, 2022
@ddimatos ddimatos changed the title [Task] [zos_blockinfile] Investigate if quotes in content can be supported [Enabler] [zos_blockinfile] Investigate if quotes in content can be supported Sep 24, 2022
@ddimatos ddimatos changed the title [Enabler] [zos_blockinfile] Investigate if quotes in content can be supported [Bug] [zos_blockinfile] Investigate if quotes in content can be supported Sep 24, 2022
@ddimatos ddimatos added Bug Something isn't working as designed. and removed Enabler Enabler task labels Sep 24, 2022
@ddimatos ddimatos modified the milestones: Enablers, Bugs Sep 24, 2022
@ddimatos ddimatos moved this from ⚙ Backlog to 📗In plan in IBM Ansible z/OS Core Collection Sep 24, 2022
@ddimatos ddimatos added the In Plan Issue has been accepted put into a planned release label Sep 24, 2022
@ddimatos ddimatos modified the milestones: Bugs , [Backlog] Bugs Sep 27, 2022
@ddimatos
Copy link
Collaborator Author

It appears ZOAU 1.2.2 resolved the issue in their python api's for issue 9120, this work item now should evaluate that fix from ZOAU an then remove the logic in the zos_blockinfile module that strips quotes.

@ddimatos ddimatos changed the title [Bug] [zos_blockinfile] Investigate if quotes in content can be supported [Bug] [zos_blockinfile] Can quotes in content can be supported Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working as designed. In Plan Issue has been accepted put into a planned release
Projects
Development

No branches or pull requests

3 participants