fix: improve actions waiting timeout based on data #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooola
force-pushed
the
unchain-actions-wait
branch
2 times, most recently
from
e519687 to
20885cd
Compare
jooola
force-pushed
the
unchain-actions-wait
branch
from
20885cd to
7028e24
Compare
apricote
approved these changes
Apr 11, 2024
apricote
approved these changes
Apr 15, 2024
jooola
pushed a commit
that referenced
this pull request
Apr 15, 2024
🤖 I have created a release *beep* *boop* --- ## [3.1.0](3.0.0...3.1.0) (2024-04-15) ### Features * assign primary ip to a server on create ([#465](#465)) ([51afb23](51afb23)) * rename server `image_allow_deprecated` option ([#487](#487)) ([d88ecdb](d88ecdb)) * use resources name or ID in server module arguments ([#484](#484)) ([7fdefcf](7fdefcf)) ### Bug Fixes * improve actions waiting timeout based on data ([#488](#488)) ([0709552](0709552)) * return sorted `alias_ips` in `server_network` module ([#458](#458)) ([1ae6769](1ae6769)) * use empty string to remove server from its placement group ([#489](#489)) ([00a4fdd](00a4fdd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Some action waiting time have been set to an arbitrary number, which could force the users to wait for too long, while we could have raised a timeout.
This changes the arbitrary numbers with rough estimate based on the average actions time and some leeway.