Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql_user follow up on column privileges #106

Closed
JaSafieddine opened this issue Mar 4, 2021 · 4 comments · Fixed by #107
Closed

mysql_user follow up on column privileges #106

JaSafieddine opened this issue Mar 4, 2021 · 4 comments · Fixed by #107

Comments

@JaSafieddine
Copy link

JaSafieddine commented Mar 4, 2021

SUMMARY

Issue #99 got partially solved by PR #100. It would be great to generalize this solution to work with all column privileges. The MySQL 8.0 documentation (https://dev.mysql.com/doc/refman/8.0/en/grant.html#grant-column-privileges) specifies the following column privileges:

INSERT, REFERENCES, SELECT, and UPDATE

ISSUE TYPE
  • Bug Report
COMPONENT NAME

mysql_user

@Andersson007
Copy link
Collaborator

@JaSafieddine thanks for the issue! I'm working on it

@Andersson007
Copy link
Collaborator

#107 the final tests passed. I made a small adjustment in tests. They should pass again, so ready for review

@Andersson007
Copy link
Collaborator

fyi: there are false codecov failings. the units and integration passed

@Andersson007
Copy link
Collaborator

@JaSafieddine thanks for reporting!
@Jorge-Rodriguez thanks for reviewing!

I've just release community.mysql 1.3.0, so the changes will appear in Ansible 3.1.0 tomorrow, hope we didn't introduce new bugs:D
Despite the CI tests, if you can try it soon, I'd be grateful for feedback
Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants