Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql_privs: Add support for procedures with ALL_IN_SCHEMA #1002

Closed
Andersson007 opened this issue Sep 29, 2020 · 3 comments · Fixed by #1048
Closed

postgresql_privs: Add support for procedures with ALL_IN_SCHEMA #1002

Andersson007 opened this issue Sep 29, 2020 · 3 comments · Fixed by #1048
Labels
database feature This issue/PR relates to a feature request has_pr module module needs_triage plugins plugin (any type) postgresql

Comments

@Andersson007
Copy link
Contributor

Andersson007 commented Sep 29, 2020 •
edited
Loading

SUMMARY

Relates to #994

postgresql_privs: Add support for procedures with ALL_IN_SCHEMA

postgresql_privs:
  database: test2_db
  privs: ALL
  roles: test
  objs: ALL_IN_SCHEMA
  type: procedure

I thinks this is relevantly easy to implement, see:

  1. postgresql_privs: fix the module mistakes a procedure for a function #996 (create a similar function and put p instead of f to the SQL query, the part without prokind can contain module.fail_json(msg="meaning: for using the feature, you need postgres 11 or later") and don't forget to put a note about postgres version 11+ in note: section and option's description, add CI tests)
  2. (postgresql_privs) accept 'ALL_IN_SCHEMA' objs for 'function' type ansible/ansible#35331 (also could be helpful)

If anybody decides to implement this, please PUT a COMMENT HERE about your intention to avoid parallel works

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

postgresql_privs
@ansibullbot
Copy link
Collaborator

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link
Collaborator

cc @Dorn- @andytom @b6d @ilicmilan @jbscalia @kostiantyn-nemchenko @matburt @nerzhul @sebasmannem @tcraxs
click here for bot help

@ansibullbot ansibullbot added affects_2.10 database feature This issue/PR relates to a feature request module module needs_triage plugins plugin (any type) postgresql labels Sep 29, 2020
@Andersson007 Andersson007 mentioned this issue Oct 6, 2020
Merged
@Andersson007
Copy link
Contributor Author

Andersson007 commented Oct 6, 2020 •
edited
Loading

Added support for procedures #1048

@patchback patchback bot mentioned this issue Oct 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
database feature This issue/PR relates to a feature request has_pr module module needs_triage plugins plugin (any type) postgresql
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

postgresql_privs: add procedure type support Andersson007/community.general
2 participants
@Andersson007 @ansibullbot