Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] Support diff mode #38

Open
MarkusTeufelberger opened this issue Apr 29, 2020 · 1 comment
Open

[all] Support diff mode #38

MarkusTeufelberger opened this issue Apr 29, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@MarkusTeufelberger
Copy link
Contributor

SUMMARY

Most/all modules in here should support returning meaningful diffs on changes.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME
ADDITIONAL INFORMATION

It generally feels a bit "empty" if a certificate or similar gets replaced with a simple [changed] notice, having a diff of the actual changes would be really helpful.

See https://blog.networktocode.com/post/generating-diff-with-ansible/ for the general return values expected by Ansible.

Some complications would probably include the fact that there could be private key material leaked and just diffing a DER-encoded file isn't going to help people either... so there should be some way to do the diffs on the parsed + decoded versions of the files we're creating/changing here rather than a straightforward text only diff.

@felixfontein
Copy link
Contributor

Some modules (I think acme_account is one) already have it, and in general it's easy to solve by filling the appropriate output fields.

It's probably easiest if most return fields are put into the diff dict (since these don't contain any private key material).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants