Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Test against newer version of MacOS (remove hack) #156

Open
gundalow opened this issue Dec 9, 2020 · 1 comment
Open

CI: Test against newer version of MacOS (remove hack) #156

gundalow opened this issue Dec 9, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@gundalow
Copy link
Contributor

gundalow commented Dec 9, 2020

SUMMARY

Currently, this collection is testing against an old version of MacOS which requires this hack

# START: HACK
if [ "${script}" == "osx" ] && [ "${ansible_version}" == "2.9" ]; then
# Make sure that the latest versions of pyOpenSSL and cryptography will be installed on macOS before
# ansible-playbook is started. This is no longer necessary for devel (https://github.com/ansible/ansible/issues/68701
# is fixed), but 2.9 still needs this since the new collection loader probably won't get backported to stable-2.9.
sed -i -e 's/cryptography.*/cryptography >= 2.9.2/g' /root/venv/lib/python2.7/site-packages/ansible_test/_data/requirements/integration.txt
echo 'pyOpenSSL >= 19.1.0' >> /root/venv/lib/python2.7/site-packages/ansible_test/_data/requirements/integration.txt
fi

If we move to a newer version of MacOS this shouldn't be required

This should be done once the move to Azure Pipelines (AZP) is complete #155

@gundalow gundalow added the enhancement New feature or request label Dec 9, 2020
@felixfontein
Copy link
Contributor

We test both against OSX and macOS, so I think we still need this hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants