Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes ec2_transit_gateway bug with empty description. #2086

Closed
wants to merge 2 commits into from

Conversation

paulczar
Copy link

@paulczar paulczar commented May 7, 2024

SUMMARY

When one or more TGWs exist with an empty description, the module will fail.

Fixes ansible-collections/amazon.aws#2368

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_transit_gateway

Copy link

@branic branic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/334cac78aa2647419ff92b66321d0a00

✔️ ansible-galaxy-importer SUCCESS in 4m 39s (non-voting)
✔️ build-ansible-collection SUCCESS in 16m 08s
✔️ ansible-test-splitter SUCCESS in 6m 59s
✔️ integration-community.aws-1 SUCCESS in 12m 05s
Skipped 21 jobs

Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this @paulczar and @branic (for reviewing).

Please could you add a changelog fragment https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to

@tremble tremble added the backport-7 PR should be backported to the stable-7 branch label May 8, 2024
@GomathiselviS
Copy link
Collaborator

Hi @paulczar I have pushed the changelog fragment. Once approved, I shall merge this PR.

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/69d332578af844768aadf7b20b8fa88b

✔️ ansible-galaxy-importer SUCCESS in 3m 17s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 45s
✔️ ansible-test-splitter SUCCESS in 4m 19s
✔️ integration-community.aws-1 SUCCESS in 10m 12s
Skipped 21 jobs

@gravesm
Copy link
Member

gravesm commented Nov 5, 2024

Closing this PR as the transit gateway module was migrated to amazon.aws. The PR has been reissued in ansible-collections/amazon.aws#2375

@gravesm gravesm closed this Nov 5, 2024
softwarefactory-project-zuul bot pushed a commit to ansible-collections/amazon.aws that referenced this pull request Nov 11, 2024
SUMMARY

When one or more TGWs exist with an empty description, the module will fail.
Fixes #2368

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ec2_transit_gateway
ADDITIONAL INFORMATION


Apparently, ansible-collections/community.aws#2086 failed to merge, and the ec2_transit_gateway module has now been migrated to amazon.aws. This PR just cherry-picks the commits on top of this repo.

Reviewed-by: Alina Buzachis
Reviewed-by: GomathiselviS <[email protected]>
patchback bot pushed a commit to ansible-collections/amazon.aws that referenced this pull request Nov 11, 2024
SUMMARY

When one or more TGWs exist with an empty description, the module will fail.
Fixes #2368

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ec2_transit_gateway
ADDITIONAL INFORMATION

Apparently, ansible-collections/community.aws#2086 failed to merge, and the ec2_transit_gateway module has now been migrated to amazon.aws. This PR just cherry-picks the commits on top of this repo.

Reviewed-by: Alina Buzachis
Reviewed-by: GomathiselviS <[email protected]>
(cherry picked from commit 69d81d5)
softwarefactory-project-zuul bot pushed a commit to ansible-collections/amazon.aws that referenced this pull request Nov 11, 2024
This is a backport of PR #2375 as merged into main (69d81d5).
SUMMARY

When one or more TGWs exist with an empty description, the module will fail.
Fixes #2368

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ec2_transit_gateway
ADDITIONAL INFORMATION


Apparently, ansible-collections/community.aws#2086 failed to merge, and the ec2_transit_gateway module has now been migrated to amazon.aws. This PR just cherry-picks the commits on top of this repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7 PR should be backported to the stable-7 branch backport-8 mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: 'Description' when deleting transit gateway
6 participants