-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes ec2_transit_gateway bug with empty description. #2086
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 39s (non-voting) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for this @paulczar and @branic (for reviewing).
Please could you add a changelog fragment https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to
sets a default description of ""
1435a04
to
213fd92
Compare
Hi @paulczar I have pushed the changelog fragment. Once approved, I shall merge this PR. |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 17s (non-voting) |
Closing this PR as the transit gateway module was migrated to amazon.aws. The PR has been reissued in ansible-collections/amazon.aws#2375 |
SUMMARY When one or more TGWs exist with an empty description, the module will fail. Fixes #2368 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_transit_gateway ADDITIONAL INFORMATION Apparently, ansible-collections/community.aws#2086 failed to merge, and the ec2_transit_gateway module has now been migrated to amazon.aws. This PR just cherry-picks the commits on top of this repo. Reviewed-by: Alina Buzachis Reviewed-by: GomathiselviS <[email protected]>
SUMMARY When one or more TGWs exist with an empty description, the module will fail. Fixes #2368 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_transit_gateway ADDITIONAL INFORMATION Apparently, ansible-collections/community.aws#2086 failed to merge, and the ec2_transit_gateway module has now been migrated to amazon.aws. This PR just cherry-picks the commits on top of this repo. Reviewed-by: Alina Buzachis Reviewed-by: GomathiselviS <[email protected]> (cherry picked from commit 69d81d5)
This is a backport of PR #2375 as merged into main (69d81d5). SUMMARY When one or more TGWs exist with an empty description, the module will fail. Fixes #2368 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_transit_gateway ADDITIONAL INFORMATION Apparently, ansible-collections/community.aws#2086 failed to merge, and the ec2_transit_gateway module has now been migrated to amazon.aws. This PR just cherry-picks the commits on top of this repo.
SUMMARY
When one or more TGWs exist with an empty description, the module will fail.
Fixes ansible-collections/amazon.aws#2368
ISSUE TYPE
COMPONENT NAME
ec2_transit_gateway