-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some fixes in ios_acls module: #998
Some fixes in ios_acls module: #998
Conversation
- Correctly take in count the case where we try to create an ACL with an ACL of another type already present. I have added the test `test_ios_acls_replaced_changetype` to test it. - For the ACL without a sequence number, correctly take in count the fake ACL number. I have also added a test in the unit test test_ios_acls_replaced_idempotent` to validate that the test correctly take in count these ACE - In unit test, the test `test_ios_acls_parsed_matches` was clearly with a wrong output format. Fixed it.
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #998 +/- ##
==========================================
- Coverage 86.74% 86.74% -0.01%
==========================================
Files 197 197
Lines 12067 12081 +14
==========================================
+ Hits 10468 10480 +12
- Misses 1599 1601 +2 |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 32s |
for more information, see https://pre-commit.ci
Hey @earendilfr, I look forward to merging this in upcoming releases, Thank you for your contribution. |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 40s |
…#1005) * revert vlan extra parameters * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add a changelog * revert vlans test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * resource segregate implementation * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * documentation update * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add basic tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * minor doc changes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * check command options * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add purge * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix unused imports * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update changelog * add tests for vlan conf * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update tests for vlan config purged * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix vlan config * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix tests * update documentation * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update docs 2 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * address review comments * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update doc * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update test-req --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
- Fixe one issue in ACL
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 56s |
@earendilfr can you please look at the conflicts? CC @roverflow |
- Correctly take in count the case where we try to create an ACL with an ACL of another type already present. I have added the test `test_ios_acls_replaced_changetype` to test it. - For the ACL without a sequence number, correctly take in count the fake ACL number. I have also added a test in the unit test test_ios_acls_replaced_idempotent` to validate that the test correctly take in count these ACE - In unit test, the test `test_ios_acls_parsed_matches` was clearly with a wrong output format. Fixed it.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
- Fixe one issue in ACL
@KB-perByte , @roverflow : I have perform the merge and the tests (for ACL module) working fine. |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 05s |
SUMMARY
Some modification done:
Currently, when we push an ACL from a type (
extended
orstandard
) but an ACL from the other type is present, module dones't delete first the previous ACL.So, we could have an error because the ACL are not compatible. The only solution was first delete the previous ACL completely
For the version IOS-XE 16.9 and for all the IOS 15.x, the ACE didn't have the sequence number. I fixe was previously done by @KB-perByte but I suspect that something still not working.
It's better with:
^\s*
prior both line for acecount
variable in config/acls/acls.py by aenumerate
functionAt the same point, I have check the unit test
test_ios_acls_parsed_matches
and I think that an "ugly" workaround was put in place to take in count that the ACE was not correctly matched and so, in test, the address object was replaced by a protocol_option object...ISSUE TYPE
COMPONENT NAME
ios_acls
ADDITIONAL INFORMATION