New collection review: cisco.dnac #20
Replies: 10 comments 25 replies
-
The collection satisfies all the requirements and is ready for review |
Beta Was this translation helpful? Give feedback.
-
Thank you for your submission, @racampos. The items in the checklist can be in one of the following states:
Feel free to ask any questions and provide feedback. Thanks in advance for your understanding. For details about the following points, refer to the Collection Requirements. Public availability and communication:
Standards and documentation:
Collection management:
Tests:
|
Beta Was this translation helpful? Give feedback.
-
Just a reminder: collections that want to be part of the Ansible 4.0.0 package need to get approval by 2021-04-26 (full schedule). This inclusion request still has some open issues that need to get addressed by then. |
Beta Was this translation helpful? Give feedback.
-
RE, using an inventory to keep connection specific information and credentials for the host in play. In this case, I prefer the use of the inventory, since these are attributes of the host in play (the DNAC server), the use of inventory seems very clean and appropriate. (I see the DNAC python pkg handles it's own HTTP auth & connections so use of the HTTP API connection here doesn't make sense) Yeah, technically, these were being used as module params and not parameters for a native connection plugin, but I think experience should have priority. I have DNAC servers in my inventory, and for each DNAC server I need to track 7 host specific attributes. host vars seems to be the right approach vs. an external vars file. +1 for the use of inventory to maintain vars that are specific to a DNAC host (independent of whether these vars are used by a action/module or connection plugin) |
Beta Was this translation helpful? Give feedback.
-
The The next opportunity for inclusion will be in about six months for Ansible 5.0.0. |
Beta Was this translation helpful? Give feedback.
-
Please note that the filename changelogs/changelogs.yaml will not be picked up by Ansible; you have to use changelogs/changelog.yaml (with one less |
Beta Was this translation helpful? Give feedback.
-
Hello @felixfontein, @gundalow, @tadeboro. Do we need to create a new discussion? We're concerned about the review process for this collection, as it has been idle. All issues were fixed long ago and it hasn't been reviewed again. |
Beta Was this translation helpful? Give feedback.
-
Ansible Collections Checklist (short version)For details about the following points, refer to the Collection Requirements. Every comment should say whether the reviewer expects it to be addressed, or whether it's optional. Public availability and communication:
Standards and documentation:
Collection management:
Tests:
|
Beta Was this translation helpful? Give feedback.
-
While looking at the changelog I noticed some entries in the past that are problematic. Please try to avoid such things in the future.
|
Beta Was this translation helpful? Give feedback.
-
Included ansible-community/ansible-build-data#125, congratulations and thanks! |
Beta Was this translation helpful? Give feedback.
-
Hello, I'd like to submit the cisco.dnac collection for review:
Beta Was this translation helpful? Give feedback.
All reactions