ec2_group - Add egress_rules and purge_egress_rules aliases #878

tremble · 2022-06-17T19:38:54Z

SUMMARY

Fix #440 - exception running with --diff and --check when creating a new SG by adding a rule referencing a missing SG.

Add egress_rules and purge_egress_rules aliases - while cleaning up the tests I kept writing "egress_rules" rather than "rules_egress".

Cleanup and re-enable ec2_group tests

Remove "Classic Networking" tests (we don't have this in CI and it'll be gone in August)
Fix Group/VPC deletion in tests (cross-referenced rules weren't being deleted, wipe the rules first)

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ec2_group

ADDITIONAL INFORMATION

fixes: #440

ansibullbot · 2022-06-17T19:39:14Z

cc @Razique @adq @jillr @s-hertel
click here for bot help

github-actions · 2022-06-17T19:41:09Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul · 2022-06-18T19:00:39Z

Build succeeded.

softwarefactory-project-zuul · 2022-06-21T13:29:52Z

Build succeeded (gate pipeline).

patchback · 2022-06-21T13:29:57Z

Backport to stable-3: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 922800d on top of patchback/backports/stable-3/922800dcc42cdb8cada21d940ef1ff2c684a4d0d/pr-878

Backporting merged PR #878 into main

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/ansible-collections/amazon.aws.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/stable-3/922800dcc42cdb8cada21d940ef1ff2c684a4d0d/pr-878 upstream/stable-3

Now, cherry-pick PR ec2_group - Add egress_rules and purge_egress_rules aliases #878 contents into that branch:
```
$ git cherry-pick -x 922800dcc42cdb8cada21d940ef1ff2c684a4d0d
```
If it'll yell at you with something like fatal: Commit 922800dcc42cdb8cada21d940ef1ff2c684a4d0d is a merge but no -m option was given., add -m 1 as follows intead:
```
$ git cherry-pick -m1 -x 922800dcc42cdb8cada21d940ef1ff2c684a4d0d
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR ec2_group - Add egress_rules and purge_egress_rules aliases #878 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/stable-3/922800dcc42cdb8cada21d940ef1ff2c684a4d0d/pr-878

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

…collections#878) ec2_group - Add egress_rules and purge_egress_rules aliases SUMMARY Fix ansible-collections#440 - exception running with --diff and --check when creating a new SG by adding a rule referencing a missing SG. Add egress_rules and purge_egress_rules aliases - while cleaning up the tests I kept writing "egress_rules" rather than "rules_egress". Cleanup and re-enable ec2_group tests Remove "Classic Networking" tests (we don't have this in CI and it'll be gone in August) Fix Group/VPC deletion in tests (cross-referenced rules weren't being deleted, wipe the rules first) ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_group ADDITIONAL INFORMATION fixes: ansible-collections#440 Reviewed-by: Alina Buzachis <None>

…collections#878) Fix IOPs io1 DB instance updates and integration tests also SUMMARY Primary this PR is to fix updates when updating iops or allocated_storage on io1 DB instances when only one param is changing. Secondarily this fixes up the tests again and is test against some improvements to the waiter configuration see linked PR. IOPs error on update attempts if only one param is being updated: error: code: InvalidParameterCombination message: You must specify both the storage size and iops when modifying the storage size or iops on a DB instance that has iops. type: Sender msg: 'Unable to modify DB instance: An error occurred (InvalidParameterCombination) when calling the ModifyDBInstance operation: You must specify both the storage size and iops when modifying the storage size or iops on a DB instance that has iops.' ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION These tests are very slow and still a little flakey but generally all pass as expected now locally. Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@45e79ed

…collections#878) Fix IOPs io1 DB instance updates and integration tests also SUMMARY Primary this PR is to fix updates when updating iops or allocated_storage on io1 DB instances when only one param is changing. Secondarily this fixes up the tests again and is test against some improvements to the waiter configuration see linked PR. IOPs error on update attempts if only one param is being updated: error: code: InvalidParameterCombination message: You must specify both the storage size and iops when modifying the storage size or iops on a DB instance that has iops. type: Sender msg: 'Unable to modify DB instance: An error occurred (InvalidParameterCombination) when calling the ModifyDBInstance operation: You must specify both the storage size and iops when modifying the storage size or iops on a DB instance that has iops.' ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION These tests are very slow and still a little flakey but generally all pass as expected now locally. Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None>

ec2_group - Add egress_rules and purge_egress_rules aliases

ce2a2c9

ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Jun 17, 2022

This comment was marked as resolved.

Sign in to view

Fix diff/check mode bug

162e008

tremble force-pushed the tests/ec2_group/enable branch from c462293 to 162e008 Compare June 18, 2022 18:42

tremble added the backport-3 PR should be backported to the stable-3 branch label Jun 18, 2022

tremble requested review from alinabuzachis and jatorcasso June 20, 2022 11:37

alinabuzachis approved these changes Jun 21, 2022

View reviewed changes

tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 21, 2022

softwarefactory-project-zuul bot merged commit 922800d into ansible-collections:main Jun 21, 2022

tremble deleted the tests/ec2_group/enable branch September 9, 2022 08:50

renovate bot mentioned this pull request Sep 18, 2022

Update dependency amazon.aws to v4 - autoclosed platan/metrics-shields-io-config#104

Closed

1 task

renovate bot mentioned this pull request Oct 4, 2022

Update dependency amazon.aws to v5 - autoclosed platan/metrics-shields-io-config#109

Closed

1 task

renovate bot mentioned this pull request Oct 27, 2022

Update dependency amazon.aws to v5 - autoclosed jkroepke/homelab#27

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ec2_group - Add egress_rules and purge_egress_rules aliases #878

ec2_group - Add egress_rules and purge_egress_rules aliases #878

tremble commented Jun 17, 2022 •

edited

Loading

ansibullbot commented Jun 17, 2022

github-actions bot commented Jun 17, 2022 •

edited

Loading

This comment was marked as resolved.

This comment was marked as resolved.

softwarefactory-project-zuul bot commented Jun 18, 2022

softwarefactory-project-zuul bot commented Jun 21, 2022

patchback bot commented Jun 21, 2022 •

edited

Loading

ec2_group - Add egress_rules and purge_egress_rules aliases #878

ec2_group - Add egress_rules and purge_egress_rules aliases #878

Conversation

tremble commented Jun 17, 2022 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibullbot commented Jun 17, 2022

github-actions bot commented Jun 17, 2022 • edited Loading

Docs Build 📝

This comment was marked as resolved.

This comment was marked as resolved.

softwarefactory-project-zuul bot commented Jun 18, 2022

softwarefactory-project-zuul bot commented Jun 21, 2022

patchback bot commented Jun 21, 2022 • edited Loading

Backport to stable-3: 💔 cherry-picking failed — conflicts found

Backporting merged PR #878 into main

tremble commented Jun 17, 2022 •

edited

Loading

github-actions bot commented Jun 17, 2022 •

edited

Loading

patchback bot commented Jun 21, 2022 •

edited

Loading