elb_classic_lb: Add integration tests for - fix return value _format_listener method to include SSLCertificateId #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
tremble
requested changes
Jun 7, 2022
| - priv_key: "{{ remote_tmp_dir }}/private-1.pem" | ||
| cert: "{{ remote_tmp_dir }}/public-1.pem" | ||
| csr: "{{ remote_tmp_dir }}/csr-1.csr" | ||
| domain: "acm1.{{ resource_prefix }}.ansible.com" |
There was a problem hiding this comment.
Suggested change
| domain: "acm1.{{ resource_prefix }}.ansible.com" | |
| domain: "elb-classic.{{ tiny_prefix }}.ansible.test" |
- IIRC resource_prefix isn't guaranteed to be valid for domain names
- It's possible that ACM will grumble about the use of
.testbut this is an example of what the.testTLD is for: https://en.wikipedia.org/wiki/.test - When it comes to debugging why resources are getting left behind it's helpful for resources to include the name of what's being tested
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
tremble
approved these changes
Jun 7, 2022
jatorcasso
pushed a commit
to jatorcasso/amazon.aws
that referenced
this pull request
Jun 27, 2022
…listener method to include SSLCertificateId (ansible-collections#864) elb_classic_lb: Add integration tests for - fix return value _format_listener method to include SSLCertificateId SUMMARY Added integration test for ansible-collections#864 ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_classic_lb Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added integration test for #860
ISSUE TYPE
COMPONENT NAME
elb_classic_lb