ec2_vpc_net - Deprecate purge_tags=False and support management by ID #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
tagging/deprecate_purge/ec2_vpc_net
branch
from
404eeed to
6c5245e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
tagging/deprecate_purge/ec2_vpc_net
branch
from
6c5245e to
6b2cb78
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ansibullbot
added
integration
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
tagging/deprecate_purge/ec2_vpc_net
branch
from
67b8546 to
6912063
Compare
This comment was marked as resolved.
This comment was marked as resolved.
tremble
changed the title
tremble
force-pushed
the
tagging/deprecate_purge/ec2_vpc_net
branch
from
6912063 to
ba3ea57
Compare
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
tagging/deprecate_purge/ec2_vpc_net
branch
from
ba3ea57 to
6f81780
Compare
tremble
changed the title
|
@markuman @alinabuzachis This turned into somewhat more of a refactor than a just purge_tags and management by ID... |
markuman
reviewed
May 30, 2022
markuman
approved these changes
May 30, 2022
Co-authored-by: Markus Bergholz <[email protected]>
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
Prepare for community.aws release 3.0.0 SUMMARY next major release ISSUE TYPE Feature Pull Request COMPONENT NAME everything Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Jill R <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@ca5ef92
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
Prepare for community.aws release 3.0.0 SUMMARY next major release ISSUE TYPE Feature Pull Request COMPONENT NAME everything Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Jill R <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@ca5ef92
1 task
1 task
1 task
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Prepare for community.aws release 3.0.0 SUMMARY next major release ISSUE TYPE Feature Pull Request COMPONENT NAME everything Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Jill R <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #844
SUMMARY
Deprecate purge_tags=False and support managing VPCs by ID which lets us change tags
ISSUE TYPE
COMPONENT NAME
ec2_vpc_net
ADDITIONAL INFORMATION