inventory aws_ec2 - allow for literal strings in hostnames #826
Conversation
ansibullbot
added
community_review
feature
jatorcasso
changed the title
Yeah, that's a good point. I'll add examples and sub options for the hostnames param. And who/what does the release depend on? |
I think it's a matter of speed :) if it's get ready before next 3.x.x release happen. |
|
@markuman @jatorcasso I guess we can include this if we merge by tomorrow. |
There was a problem hiding this comment.
The only thing as @markuman suggested, please add an example. Other than that, LGTM!
alinabuzachis
added
the
backport-3
Updated docs with suboptions and example - |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #836 🤖 @patchback |
inventory aws_ec2 - allow for literal strings in hostnames SUMMARY Allow for literal strings in hostnames rather than throwing an AnsibleError Fixes #814 ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ec2 ADDITIONAL INFORMATION Is there a better way of allowing for literal strings here? Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None> (cherry picked from commit 944bb1f)
[PR #826/944bb1fe backport][stable-3] inventory aws_ec2 - allow for literal strings in hostnames This is a backport of PR #826 as merged into main (944bb1f). SUMMARY Allow for literal strings in hostnames rather than throwing an AnsibleError Fixes #814 ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ec2 ADDITIONAL INFORMATION Is there a better way of allowing for literal strings here? Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None>
…ansible-collections#826) Respect wait parameter in elb_instance when adding/removing instances SUMMARY The wait parameter is currently ignored when registering or deregistering an instance with an ELB. Looks like this was lost in the boto3 migration: 96f1518 Related: ansible-collections#825 ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_instance ADDITIONAL INFORMATION See ansible-collections#825 Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]>
…ansible-collections#826) Respect wait parameter in elb_instance when adding/removing instances SUMMARY The wait parameter is currently ignored when registering or deregistering an instance with an ELB. Looks like this was lost in the boto3 migration: 96f1518 Related: ansible-collections#825 ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_instance ADDITIONAL INFORMATION See ansible-collections#825 Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]>
…ansible-collections#826) Respect wait parameter in elb_instance when adding/removing instances SUMMARY The wait parameter is currently ignored when registering or deregistering an instance with an ELB. Looks like this was lost in the boto3 migration: 96f1518 Related: ansible-collections#825 ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_instance ADDITIONAL INFORMATION See ansible-collections#825 Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]>
SUMMARY
Allow for literal strings in hostnames rather than throwing an AnsibleError
Fixes #814
ISSUE TYPE
COMPONENT NAME
aws_ec2
ADDITIONAL INFORMATION
Is there a better way of allowing for literal strings here?