Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy ignore-2.13.txt to ignore-2.14.txt #749

Conversation

alinabuzachis
Copy link
Collaborator

SUMMARY

Relates to ansible-collections/news-for-maintainers#13

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@alinabuzachis alinabuzachis requested review from tremble and jillr March 29, 2022 10:02
@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review needs_triage tests tests labels Mar 29, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@tremble tremble added backport-1.5 PR should be backported to the stable-1.5 branch backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch labels Mar 29, 2022
@markuman
Copy link
Member

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Mar 29, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 42295a7 into ansible-collections:main Mar 29, 2022
@patchback
Copy link

patchback bot commented Mar 29, 2022

Backport to stable-1.5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-1.5/42295a733d52daa6f3f58ace2fdd8cd0c457bf2e/pr-749

Backported as #753

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 29, 2022
Copy ignore-2.13.txt to ignore-2.14.txt

SUMMARY

Relates to ansible-collections/news-for-maintainers#13

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>
(cherry picked from commit 42295a7)
@patchback
Copy link

patchback bot commented Mar 29, 2022

Backport to stable-2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2/42295a733d52daa6f3f58ace2fdd8cd0c457bf2e/pr-749

Backported as #754

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 29, 2022
Copy ignore-2.13.txt to ignore-2.14.txt

SUMMARY

Relates to ansible-collections/news-for-maintainers#13

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>
(cherry picked from commit 42295a7)
@patchback
Copy link

patchback bot commented Mar 29, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/42295a733d52daa6f3f58ace2fdd8cd0c457bf2e/pr-749

Backported as #755

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 29, 2022
Copy ignore-2.13.txt to ignore-2.14.txt

SUMMARY

Relates to ansible-collections/news-for-maintainers#13

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>
(cherry picked from commit 42295a7)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 29, 2022
[PR #749/42295a73 backport][stable-3] Copy ignore-2.13.txt to ignore-2.14.txt

This is a backport of PR #749 as merged into main (42295a7).
SUMMARY

Relates to ansible-collections/news-for-maintainers#13

ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 30, 2022
[PR #749/42295a73 backport][stable-2] Copy ignore-2.13.txt to ignore-2.14.txt

This is a backport of PR #749 as merged into main (42295a7).
SUMMARY

Relates to ansible-collections/news-for-maintainers#13

ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Mar 31, 2022
…sible-collections#755)

[PR ansible-collections#749/42295a73 backport][stable-3] Copy ignore-2.13.txt to ignore-2.14.txt

This is a backport of PR ansible-collections#749 as merged into main (42295a7).
SUMMARY

Relates to ansible-collections/news-for-maintainers#13

ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 12, 2022
…e-2.14.txt (#753)

[PR #749/42295a73 backport][stable-1.5] Copy ignore-2.13.txt to ignore-2.14.txt

This is a backport of PR #749 as merged into main (42295a7).
SUMMARY

Relates to ansible-collections/news-for-maintainers#13

ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…sible-collections#881)

Fix cloudfront_distribution s3_origin_access_identity_enabled bug

SUMMARY
If s3_origin_access_identity_enabled is set to True but no s3_origin_config then a default origin config is applied however it also picks up s3_origin_access_identity_enabled as S3OriginAccessIdentityEnabled and passes it to the API request which is not a valid option to be passed and then fails validation.
Fixes: ansible-collections#749
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
cloudfront_distribution
ADDITIONAL INFORMATION
The option mention is not valid for the API request:
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/cloudfront.html#CloudFront.Client.create_distribution

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…sible-collections#881)

Fix cloudfront_distribution s3_origin_access_identity_enabled bug

SUMMARY
If s3_origin_access_identity_enabled is set to True but no s3_origin_config then a default origin config is applied however it also picks up s3_origin_access_identity_enabled as S3OriginAccessIdentityEnabled and passes it to the API request which is not a valid option to be passed and then fails validation.
Fixes: ansible-collections#749
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
cloudfront_distribution
ADDITIONAL INFORMATION
The option mention is not valid for the API request:
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/cloudfront.html#CloudFront.Client.create_distribution

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…sible-collections#881)

Fix cloudfront_distribution s3_origin_access_identity_enabled bug

SUMMARY
If s3_origin_access_identity_enabled is set to True but no s3_origin_config then a default origin config is applied however it also picks up s3_origin_access_identity_enabled as S3OriginAccessIdentityEnabled and passes it to the API request which is not a valid option to be passed and then fails validation.
Fixes: ansible-collections#749
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
cloudfront_distribution
ADDITIONAL INFORMATION
The option mention is not valid for the API request:
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/cloudfront.html#CloudFront.Client.create_distribution

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-1.5 PR should be backported to the stable-1.5 branch backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch bug This issue/PR relates to a bug community_review mergeit Merge the PR (SoftwareFactory) needs_triage tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants