Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_s3: Add latest choice on overwrite parameter #595

Merged
merged 9 commits into from
Jan 12, 2022
Merged

aws_s3: Add latest choice on overwrite parameter #595

merged 9 commits into from
Jan 12, 2022

Conversation

na4da
Copy link
Contributor

@na4da na4da commented Dec 23, 2021

SUMMARY

This PR adds latest choice on overwrite parameter to get remote object only when it's the latest. If a local object is the latest, or local and remote objects have identical last-modified timestamps, overwriting is ignored.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

aws_s3

ADDITIONAL INFORMATION

Motivation: when using the different choice, getting a large sized object takes few minutes whether local and remote objects are identical or not because of MD5 calculation.

@na4da na4da force-pushed the modules/s3-latest-choice branch from 6b9aba7 to 23328bf Compare December 24, 2021 10:15
@na4da
Copy link
Contributor Author

na4da commented Dec 24, 2021

I think the cause of the integration test failure is probably same as #553 (comment)

...

Including module_utils file ansible/module_utils/facts/virtual/base.py
Including module_utils file ansible/module_utils/facts/virtual/__init__.py
Including module_utils file ansible/module_utils/facts/virtual/dragonfly.py
Including module_utils file ansible/module_utils/facts/virtual/freebsd.py
Including module_utils file ansible/module_utils/facts/virtual/hpux.py
Including module_utils file ansible/module_utils/facts/virtual/linux.py
Including module_utils file ansible/module_utils/facts/virtual/netbsd.py
Including module_utils file ansible/module_utils/facts/virtual/openbsd.py
Including module_utils file ansible/module_utils/facts/virtual/sunos.py
Including module_utils file ansible/module_utils/facts/virtual/sysctl.py
Including module_utils file ansible/module_utils/parsing/convert_bool.py
Including module_utils file ansible/module_utils/parsing/__init__.py
Including module_utils file ansible/module_utils/pycompat24.py
Including module_utils file ansible/module_utils/six/__init__.py
Using module file /tmp/ansible-test-_742usfx/ansible/modules/setup.py
Pipelining is enabled.
<testhost> ESTABLISH LOCAL CONNECTION FOR USER: zuul
<testhost> EXEC /bin/sh -c 'ANSIBLE_DEBUG_BOTOCORE_LOGS=True /home/zuul/venv/bin/python && sleep 0'
fatal: [testhost]: FAILED! => {
    "ansible_facts": {},
    "changed": false,
    "failed_modules": {
        "ansible.legacy.setup": {
            "exception": "Traceback (most recent call last):\n  File \"<stdin>\", line 121, in <module>\n  File \"<stdin>\", line 109, in _ansiballz_main\nOSError: [Errno 28] No space left on device\n",
            "failed": true,
            "module_stderr": "Traceback (most recent call last):\n  File \"<stdin>\", line 121, in <module>\n  File \"<stdin>\", line 109, in _ansiballz_main\nOSError: [Errno 28] No space left on device\n",
            "module_stdout": "",
            "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error",
            "rc": 1
        }
    },
    "msg": "The following modules failed to execute: ansible.legacy.setup\n"
}

PLAY RECAP *********************************************************************
testhost                   : ok=0    changed=0    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0   

Command exited with status 2 after 3.111757278442383 seconds.
ERROR: Command "ansible-playbook aws_s3-h3fa9w56.yml -i inventory --skip-tags False --diff -vvvvvv" returned exit status 2.
ERROR: The 1 integration test(s) listed below (out of 1) failed. See error output above for details:
aws_s3
Cleaning up temporary python directory: /tmp/python-e5nisutt-ansible

@alinabuzachis
Copy link
Collaborator

@na4da Thank you for working on this. Something like this #590 might fix the error.

@na4da
Copy link
Contributor Author

na4da commented Dec 27, 2021

@alinabuzachis OK. In that case, I'll wait for merging #590 and then rebase this PR.

@alinabuzachis
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@alinabuzachis
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@jillr jillr added the gate label Jan 12, 2022
ansible-zuul[bot]
ansible-zuul bot approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 4000d58 into ansible-collections:main Jan 12, 2022
@na4da na4da deleted the modules/s3-latest-choice branch January 13, 2022 00:51
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@kbrebanov @tremble
Add changelog fragment for pull request ansible-collections#595
83dd7ba
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@ansible-zuul
Merge pull request ansible-collections#595 from kbrebanov/fix-route53…
4babc11 
…-identifier

route53: Identifier missing from resource_record_set.

SUMMARY

Currently, the identifier parameter is never included in resource_record_set.

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

route53
ADDITIONAL INFORMATION


The identifier parameter is always nullified as it's not included in resource_record_set.
This change allows the identifier to be included and scrubbed if None.

Reviewed-by: Mark Chappell <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@jillr jillr jillr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@na4da @alinabuzachis @jillr