Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to work around more DigitalOcean S3 incompatabilities #530

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 8, 2021

SUMMARY

fixes: #508

Trying to update S3 buckets with DigitalOcean is apparently failing again. Try to work around this.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

s3_bucket

ADDITIONAL INFORMATION

@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review has_issue module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Oct 8, 2021
@tremble
Copy link
Contributor Author

tremble commented Oct 12, 2021

recheck

Copy link
Collaborator

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sensible to me. Just curious if it has solved #508.

@tremble
Copy link
Contributor Author

tremble commented Oct 18, 2021

@alinabuzachis Yeah, I was hoping @eeshugerman would have chance to test. We at least know I didn't break Amazon compat in the process...

Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eeshugerman
Copy link

Sorry for the delay folks. I will test this against DO this evening.

@eeshugerman
Copy link

Yep, this fixes #508 for me. Thanks!

@tremble tremble added gate and removed gate labels Oct 19, 2021
@ansible-zuul ansible-zuul bot merged commit 3325b50 into ansible-collections:main Oct 19, 2021
@tremble tremble deleted the issues/508 branch November 26, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review has_issue module module owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s3_bucket | DigitalOcean compatibility (KeyError: Rules)
4 participants