Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ec2_eni tagging code #522

Merged
merged 4 commits into from
Oct 6, 2021
Merged

Refactor ec2_eni tagging code #522

merged 4 commits into from
Oct 6, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 4, 2021

SUMMARY

Use the shared ec2 tagging code for tagging ENIs.

Also fixes the test instability (caused by a race condition with VM states)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_eni

ADDITIONAL INFORMATION

@ansibullbot
Copy link

cc @healem @jillr @s-hertel @wimnat
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Oct 4, 2021
@tremble tremble requested a review from alinabuzachis October 4, 2021 17:38
@tremble tremble requested a review from felixfontein October 5, 2021 13:13
@jillr jillr removed the needs_triage label Oct 5, 2021
@tremble @alinabuzachis
fix import - too aggressive
f52424d 
Co-authored-by: Alina Buzachis <[email protected]>
@tremble tremble added the gate label Oct 6, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tremble tremble added gate and removed gate labels Oct 6, 2021
@ansible-zuul ansible-zuul bot merged commit a1ef229 into ansible-collections:main Oct 6, 2021
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 27, 2021
@tremble @alinabuzachis
Refactor ec2_eni tagging code (ansible-collections#522)
024cd30 
Refactor ec2_eni tagging code

SUMMARY
Use the shared ec2 tagging code for tagging ENIs.
Also fixes the test instability (caused by a race condition with VM states)
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_eni
ADDITIONAL INFORMATION

Reviewed-by: Felix Fontein <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 27, 2021
@tremble @alinabuzachis
Refactor ec2_eni tagging code (ansible-collections#522)
30bfe08 
Refactor ec2_eni tagging code

SUMMARY
Use the shared ec2 tagging code for tagging ENIs.
Also fixes the test instability (caused by a race condition with VM states)
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_eni
ADDITIONAL INFORMATION

Reviewed-by: Felix Fontein <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
@tremble tremble deleted the tags/ec2_eni branch November 26, 2021 12:42
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Dec 2, 2021
@tremble @alinabuzachis
Refactor ec2_eni tagging code (ansible-collections#522)
406cc9f 
Refactor ec2_eni tagging code

SUMMARY
Use the shared ec2 tagging code for tagging ENIs.
Also fixes the test instability (caused by a race condition with VM states)
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_eni
ADDITIONAL INFORMATION

Reviewed-by: Felix Fontein <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@berenddeboer
efs - Add support to specify the number of days to transition to inac…
36c5c07 
…tive storage (ansible-collections#522)

efs - Add support to specify the number of days to transition to inactive storage

SUMMARY
Support setting EFS lifecycle policy.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
community.aws.efs
ADDITIONAL INFORMATION
This is now possible:
- name: Set a lifecycle policy
  community.aws.efs:
    state: present
    name: myTestEFS
    transition_to_ia: 7
    targets:
        - subnet_id: subnet-7654fdca
          security_groups: [ "sg-4c5d6f7a" ]

- name: Remove a lifecycle policy
  community.aws.efs:
    state: present
    name: myTestEFS
    transition_to_ia: None
    targets:
        - subnet_id: subnet-7654fdca
          security_groups: [ "sg-4c5d6f7a" ]

Reviewed-by: Mark Chappell <None>
Reviewed-by: Jill R <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@berenddeboer @abikouo
efs - Add support to specify the number of days to transition to inac…
0aca75e 
…tive storage (ansible-collections#522)

efs - Add support to specify the number of days to transition to inactive storage

SUMMARY
Support setting EFS lifecycle policy.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
community.aws.efs
ADDITIONAL INFORMATION
This is now possible:
- name: Set a lifecycle policy
  community.aws.efs:
    state: present
    name: myTestEFS
    transition_to_ia: 7
    targets:
        - subnet_id: subnet-7654fdca
          security_groups: [ "sg-4c5d6f7a" ]

- name: Remove a lifecycle policy
  community.aws.efs:
    state: present
    name: myTestEFS
    transition_to_ia: None
    targets:
        - subnet_id: subnet-7654fdca
          security_groups: [ "sg-4c5d6f7a" ]

Reviewed-by: Mark Chappell <None>
Reviewed-by: Jill R <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@berenddeboer
efs - Add support to specify the number of days to transition to inac…
1c1fae3 
…tive storage (ansible-collections#522)

efs - Add support to specify the number of days to transition to inactive storage

SUMMARY
Support setting EFS lifecycle policy.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
community.aws.efs
ADDITIONAL INFORMATION
This is now possible:
- name: Set a lifecycle policy
  community.aws.efs:
    state: present
    name: myTestEFS
    transition_to_ia: 7
    targets:
        - subnet_id: subnet-7654fdca
          security_groups: [ "sg-4c5d6f7a" ]

- name: Remove a lifecycle policy
  community.aws.efs:
    state: present
    name: myTestEFS
    transition_to_ia: None
    targets:
        - subnet_id: subnet-7654fdca
          security_groups: [ "sg-4c5d6f7a" ]

Reviewed-by: Mark Chappell <None>
Reviewed-by: Jill R <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@felixfontein felixfontein Awaiting requested review from felixfontein

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tremble @ansibullbot @felixfontein @alinabuzachis @jillr