Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_snapshot - boto3 migration #356

Merged
merged 4 commits into from
May 5, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 4, 2021

SUMMARY

Migrate ec2_snapshot to boto3

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_snapshot

ADDITIONAL INFORMATION

Assumes Python 3.x (datetime.timezone.utc)

@tremble tremble requested review from alinabuzachis, jillr and abikouo May 4, 2021 15:48
@tremble tremble force-pushed the boto3/ec2_snapshot branch from ce0b57a to a3087bf Compare May 4, 2021 17:10
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @tremble, this looks pretty good.

plugins/modules/ec2_snapshot.py Outdated Show resolved Hide resolved
@tremble tremble force-pushed the boto3/ec2_snapshot branch from a3087bf to 40f8a48 Compare May 5, 2021 03:37
Copy link
Contributor

@abikouo abikouo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tremble tremble added the gate label May 5, 2021
@tremble
Copy link
Contributor Author

tremble commented May 5, 2021

Two cloud LGTMs, letting zuul / gate do its thing

@ansible-zuul ansible-zuul bot merged commit b7087f4 into ansible-collections:main May 5, 2021
jillr pushed a commit to jillr/amazon.aws that referenced this pull request May 10, 2021
…-collections#356)

* syncing module and tests for uptime

with tons of help from Yanis, we now have uptime in there

* updating pr with fixes from suggestions

adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos

* Create 356_add_minimum_uptime_parameter.yaml

adding changelog fragment per @gravesm suggestion

* Update 356_add_minimum_uptime_parameter.yaml

last comment from @tremble

Co-authored-by: Sean Cavanaugh <[email protected]>
jillr pushed a commit to jillr/amazon.aws that referenced this pull request May 10, 2021
…-collections#356)

* syncing module and tests for uptime

with tons of help from Yanis, we now have uptime in there

* updating pr with fixes from suggestions

adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos

* Create 356_add_minimum_uptime_parameter.yaml

adding changelog fragment per @gravesm suggestion

* Update 356_add_minimum_uptime_parameter.yaml

last comment from @tremble

Co-authored-by: Sean Cavanaugh <[email protected]>
jillr pushed a commit to jillr/amazon.aws that referenced this pull request May 13, 2021
…-collections#356)

* syncing module and tests for uptime

with tons of help from Yanis, we now have uptime in there

* updating pr with fixes from suggestions

adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos

* Create 356_add_minimum_uptime_parameter.yaml

adding changelog fragment per @gravesm suggestion

* Update 356_add_minimum_uptime_parameter.yaml

last comment from @tremble

Co-authored-by: Sean Cavanaugh <[email protected]>
@tremble tremble deleted the boto3/ec2_snapshot branch May 28, 2021 07:07
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 23, 2022
…ts is 5 (#786)

Create extra snapshots for ec2_snapshot_info test - minimum max_results is 5

This is a partial backport of PR #356 as merged into main (b7087f4).
SUMMARY
Fixes a bug in the integration test
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_snapshot_info
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…-collections#356)

* syncing module and tests for uptime

with tons of help from Yanis, we now have uptime in there

* updating pr with fixes from suggestions

adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos

* Create 356_add_minimum_uptime_parameter.yaml

adding changelog fragment per @gravesm suggestion

* Update 356_add_minimum_uptime_parameter.yaml

last comment from @tremble

Co-authored-by: Sean Cavanaugh <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…-collections#356)

* syncing module and tests for uptime

with tons of help from Yanis, we now have uptime in there

* updating pr with fixes from suggestions

adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos

* Create 356_add_minimum_uptime_parameter.yaml

adding changelog fragment per @gravesm suggestion

* Update 356_add_minimum_uptime_parameter.yaml

last comment from @tremble

Co-authored-by: Sean Cavanaugh <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…-collections#356)

* syncing module and tests for uptime

with tons of help from Yanis, we now have uptime in there

* updating pr with fixes from suggestions

adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos

* Create 356_add_minimum_uptime_parameter.yaml

adding changelog fragment per @gravesm suggestion

* Update 356_add_minimum_uptime_parameter.yaml

last comment from @tremble

Co-authored-by: Sean Cavanaugh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants