Add common helper for ec2 client 'ensure_tags'

[tremble]

Depends-On: ansible/ansible-zuul-jobs#876

SUMMARY

We're copy&pasting our 'ensure_tags' code all over the place. Move the ensure_tags code for EC2 resources into module_utils

Note: It might work for other boto3 clients, but it's intended only for ec2 boto3 clients (unfortunately boto3 isn't consistent)

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

ec2_vol
ec2_vpc_subnet
ec2_tag
ec2_tag_info

ADDITIONAL INFORMATION

Todo:

• unit tests
• changelog

[ansibullbot]

cc @brandond @jillr @lwade @s-hertel @wimnat
click here for bot help

[jillr]

I also had this in my TODO backlog so thanks very much for beating me to it @tremble :)
Unit tests would be most welcome.

[ansibullbot]

cc @flowerysong
click here for bot help

[tremble]

After discussion with @jillr we don't think it's worth trying to build unit tests, the code is thoroughly tested by integration tests

[tremble]

@jillr if possible I'd like to get this in before 2.0.0, not bothered about 1.5.0

[alinabuzachis]

LGTM. Thank you @tremble.

[tremble]

recheck

[tremble]

For some reason it failed to find community.aws.ec2_instance...

[alinabuzachis]

For some reason it failed to find community.aws.ec2_instance...

@tremble I was just looking at your errors on Zuul. I got the same here #334. I talked with Jill yesterday and they suggested to try with the FQDN for the ec2_instance and ec2_instance_info. I wait for the CI now.

[tremble]

It's a little strange because it said it was redirecting it to community.aws.ec2_instance...

[alinabuzachis]

It's a little strange because it said it was redirecting it to community.aws.ec2_instance...

Yes, you are right... so this shouldn't be the problem. However, I tried to explicitly use the FQDN (it didn't help). I noticed the same error in the other PRs as well. I will try asking Gonéri later.

[goneri]

recheck

[goneri]

It's a little strange because it said it was redirecting it to community.aws.ec2_instance...

Yes, you are right... so this shouldn't be the problem. However, I tried to explicitly use the FQDN (it didn't help). I noticed the same error in the other PRs as well. I will try asking Gonéri later.

Indeed, there is nothing from a CI perspective that define the dependency between the two collections. I've pushed a fix to address the problem.