Adds the ability to use bypath to aws_secrets lookup #192
+197
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dlundgren thanks for the PR. We appreciate your help with this. cc @gundalow |
|
@dlundgren We would like to get this PR landed. Could you rebase this so I can review it soon? |
dlundgren
force-pushed
the
dl-add-bypath-to-secrets-lookup
branch
from
6cae0b0 to
4069fce
Compare
|
@gravesm I've rebased as requested, please let me know if there is any thing else I can do help get this reviewed. |
Akasurde
requested changes
Dec 21, 2020
|
@dlundgren Thanks for all your work on this. One last request and then I think we can get it merged. Could you add a changelog fragment for this PR? See: https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment. |
felixfontein
reviewed
Jan 8, 2021
felixfontein
approved these changes
Jan 9, 2021
|
(mainly looked at docs changes) |
gravesm
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds
bypathfunctionality to theaws_secretslookup. This allows it to work similar to theaws_ssmlookup plugin.ISSUE TYPE
COMPONENT NAME
aws_secrets