Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_key: support ed25519 key-type #572

Closed
1 task done
joejulian opened this issue Nov 20, 2021 · 1 comment · Fixed by #616
Closed
1 task done

ec2_key: support ed25519 key-type #572

joejulian opened this issue Nov 20, 2021 · 1 comment · Fixed by #616
Labels
jira WIP Work in progress

Comments

@joejulian
Copy link

Summary

Newer distros are beginning to disable rsa sha-1 public keys by default. Supporting the more secure ed25519 key types would allow users to utilize best practices (as long as they're not using them for windows instances). The Windows deficiency should be called out in documentation and the default should remain rsa until this deficiency is fixed by aws.

Issue Type

Feature Idea

Component Name

ec2_key

Additional Information

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@tremble
Copy link
Contributor

tremble commented Nov 20, 2021

This certainly sounds like a good feature.

Would you be interested in trying to add it?

Note for anyone implementing: botocore version 1.21.23 or later will be required for this, and will need to be explicitly used when testing in CI and should only be used when explicitly testing with an ed25519 key. Compatability with botocore == 1.18.0 must be maintained when using RSA based keys.

@abikouo abikouo added the WIP Work in progress label Jan 14, 2022
@tremble tremble linked a pull request Jan 17, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira WIP Work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants