[WIP] elb_classic_lb: fix return value _format_listener method to inc…

…lude SSLCertificateId (#860)

[WIP] elb_classic_lb: fix return value _format_listener method to include SSLCertificateId

SUMMARY

Fixes #686.
Current return value of _format_listener method does not include SSLCertificateId even if it is provided in the playbook, causing the failure as reported in above mentioned issue.
Sample return value:
{'InstancePort': 8080, 'InstanceProtocol': 'HTTP', 'LoadBalancerPort': 443, 'Protocol': 'HTTPS'}

This can be fixed by modifying the return value of _format_listener method to formatted_listener, which includes SSLCertificateId if provided in the playbook.
Sample return Value:
{'InstancePort': 8080, 'InstanceProtocol': 'HTTP', 'LoadBalancerPort': 443, 
'Protocol': 'HTTPS', 'SSLCertificateId': 'arn:aws:acm:us-east-1:1234...'}


ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

elb_classic_lb

Reviewed-by: Mark Chappell <None>

changelogs/fragments/860-elb_classic_lb-create-https-listeners.yml

@@ -0,0 +1,2 @@
+bugfixes:
+- elb_classic_lb - modify the return value of _format_listeners method to resolve a failure creating https listeners (https://github.com/ansible-collections/amazon.aws/pull/860).

plugins/modules/elb_classic_lb.py

@@ -890,7 +890,7 @@ def _format_listener(self, listener, inject_protocol=False):
         if ssl_id:
             formatted_listener['SSLCertificateId'] = ssl_id
 
-        return snake_dict_to_camel_dict(listener, True)
+        return formatted_listener
 
     def _format_healthcheck_target(self):
         """Compose target string from healthcheck parameters"""