Skip to content

Commit

Permalink
Fix linting issues. (#701)
Browse files Browse the repository at this point in the history
Fix linting issues reported by validate-modules in plugins

SUMMARY
See ansible-collections/news-for-maintainers#9.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
various

Reviewed-by: Jill R <None>
  • Loading branch information
felixfontein authored Mar 4, 2022
1 parent 1965b05 commit 211d16f
Show file tree
Hide file tree
Showing 8 changed files with 22 additions and 15 deletions.
9 changes: 9 additions & 0 deletions changelogs/fragments/validate-plugins.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
bugfixes:
- "aws_resource_actions callback plugin - fix linting errors in documentation data (https://github.com/ansible-collections/amazon.aws/pull/701)."
- "aws_ec2 inventory plugin - fix linting errors in documentation data (https://github.com/ansible-collections/amazon.aws/pull/701)."
- "aws_rds inventory plugin - fix linting errors in documentation data (https://github.com/ansible-collections/amazon.aws/pull/701)."
- "aws_account_attribute lookup plugin - fix linting errors in documentation data (https://github.com/ansible-collections/amazon.aws/pull/701)."
- "aws_account_attribute lookup plugin - fix linting errors in documentation data (https://github.com/ansible-collections/amazon.aws/pull/701)."
- "aws_secret lookup plugin - fix linting errors in documentation data (https://github.com/ansible-collections/amazon.aws/pull/701)."
- "aws_service_ip_ranges lookup plugin - fix linting errors in documentation data (https://github.com/ansible-collections/amazon.aws/pull/701)."
- "aws_ssm lookup plugin - fix linting errors in documentation data (https://github.com/ansible-collections/amazon.aws/pull/701)."
2 changes: 1 addition & 1 deletion plugins/callback/aws_resource_actions.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
__metaclass__ = type

DOCUMENTATION = '''
callback: aws_resource_actions
name: aws_resource_actions
type: aggregate
short_description: summarizes all "resource:actions" completed
description:
Expand Down
1 change: 0 additions & 1 deletion plugins/inventory/aws_ec2.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

DOCUMENTATION = '''
name: aws_ec2
plugin_type: inventory
short_description: EC2 inventory source
requirements:
- boto3
Expand Down
5 changes: 2 additions & 3 deletions plugins/inventory/aws_rds.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

DOCUMENTATION = '''
name: aws_rds
plugin_type: inventory
short_description: rds instance source
description:
- Get instances and clusters from Amazon Web Services RDS.
Expand Down Expand Up @@ -49,8 +48,8 @@
- The suffix for host variables names coming from AWS.
type: str
version_added: 3.1.0
note:
Ansible versions prior to 2.10 should use the fully qualified plugin name 'amazon.aws.aws_rds'.
notes:
- Ansible versions prior to 2.10 should use the fully qualified plugin name 'amazon.aws.aws_rds'.
extends_documentation_fragment:
- inventory_cache
- constructed
Expand Down
4 changes: 2 additions & 2 deletions plugins/lookup/aws_account_attribute.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
__metaclass__ = type

DOCUMENTATION = '''
lookup: aws_account_attribute
name: aws_account_attribute
author:
- Sloane Hertel <[email protected]>
- Sloane Hertel (@s-hertel) <[email protected]>
requirements:
- python >= 3.6
- boto3
Expand Down
4 changes: 2 additions & 2 deletions plugins/lookup/aws_secret.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
__metaclass__ = type

DOCUMENTATION = r'''
lookup: aws_secret
name: aws_secret
author:
- Aaron Smith <[email protected]>
- Aaron Smith (!UNKNOWN) <[email protected]>
requirements:
- python >= 3.6
- boto3
Expand Down
4 changes: 2 additions & 2 deletions plugins/lookup/aws_service_ip_ranges.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
__metaclass__ = type

DOCUMENTATION = '''
lookup: aws_service_ip_ranges
name: aws_service_ip_ranges
author:
- James Turner <[email protected]>
- James Turner (!UNKNOWN) <[email protected]>
requirements:
- must have public internet connectivity
short_description: Look up the IP ranges for services provided in AWS such as EC2 and S3.
Expand Down
8 changes: 4 additions & 4 deletions plugins/lookup/aws_ssm.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
__metaclass__ = type

DOCUMENTATION = '''
lookup: aws_ssm
name: aws_ssm
author:
- Bill Wang <ozbillwang(at)gmail.com>
- Marat Bakeev <hawara(at)gmail.com>
- Michael De La Rue <[email protected]>
- Bill Wang (!UNKNOWN) <ozbillwang(at)gmail.com>
- Marat Bakeev (!UNKNOWN) <hawara(at)gmail.com>
- Michael De La Rue (!UNKNOWN) <[email protected]>
requirements:
- python >= 3.6
- boto3
Expand Down

0 comments on commit 211d16f

Please sign in to comment.