-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.65.0: action fails with exit code 141 pipefail #269
Comments
whats the result of this?
also can you share more context of how your workflow operates? I see you run based on customtags instead of auto discovery also what do you mean that fails 50% of the time? |
have a look at this https://unix.stackexchange.com/questions/580117/debugging-sporadic-141-shell-script-errors regarding head command and number of filters... I see u have 400 patch tags do they all exist in the repo history? |
To me sounds the head command is signaling 141 after line 84 not necessarily after line 85 (85 does not even start) |
if this is the case we need to figure out a way to handle SIGPIPE as feature request (in between clearup some tags) or remain in 1.62 or lower for now. Interesting scenario |
When ran locally the result of this is 0. I'd imagine that it's not zero when the pipeline fails, but I can't confirm this. I'll fork this repo see if I can capture the output of this today in the pipeline.
Yup in short our workflow:
The
Yup they all exist in the repo history, the real output of |
@sbe-arg thanks for taking a look at this so quickly, it's very much appreciated 🙇 |
Ill try to debug further next week, need to simulate 500 tags or so to get a realistic scenario XD |
@sbe-arg I setup a repo with 998 tags to repro the error. Note, I also forked the action, updated it to not exit immediately on piperrors, and to log the pipe exit status for the command causing the error. Test repo with 998 tags: https://github.com/baumac/actions-test-repo Here's a GH actions run that produces the Pipefailure in the logs: https://github.com/baumac/actions-test-repo/actions/runs/5024209249/jobs/9009683359 Relevant snippet:
|
Maybe add a sleep between tag and pretag greps to make sure is happening in tag. But we can probably do a $? 141 || true as dirty fix to ignore sigpipe |
Another simple way to fix this is split the tag pretag one lines into 2 functions Where Because pipe with grep is making the git command to still piping info when grep already finishes with 0 so the pipe returns a 141 |
Created #270 which implements your suggested fix of using vars. Was able to test it out, and everything appears to be working 😄 |
Summary
We updated the action from v.1.62.0 -> v1.65.0 and now the action is failing ~50% of the time with
Docker Action run completed with exit code 141
which we believe is the result of a pipe error occurring on line 85 of entrypoint.sh.Debug Logs
The text was updated successfully, but these errors were encountered: