Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme for pre-releases as the checkout needs ref: sha #266

Closed
sbe-arg opened this issue May 15, 2023 · 0 comments · Fixed by #268
Closed

Update readme for pre-releases as the checkout needs ref: sha #266

sbe-arg opened this issue May 15, 2023 · 0 comments · Fixed by #268
Assignees

Comments

@sbe-arg
Copy link
Collaborator

sbe-arg commented May 15, 2023

in order for pre-release branch validation to work its needs to be clear that the workflow checkout requires the sha

      - uses: actions/checkout@v3
        with:
          ref: ${{ github.sha }}
          fetch-depth: 0

non having the sha in some scenarios resolves to main, master with a the default RELEASE_BRANCHES array resulting in a always pre-release set to false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant