From df84dee1b6fc6c541b1398d7e6e05e045c458bb4 Mon Sep 17 00:00:00 2001 From: James Hiew Date: Mon, 7 Nov 2022 15:38:08 +0000 Subject: [PATCH 1/2] fix: require_latest_height check should skip for requests with height 0 --- shared/src/ledger/queries/mod.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/shared/src/ledger/queries/mod.rs b/shared/src/ledger/queries/mod.rs index 8b31376be4..e9b01fd45a 100644 --- a/shared/src/ledger/queries/mod.rs +++ b/shared/src/ledger/queries/mod.rs @@ -10,6 +10,7 @@ pub use types::{ use super::storage::{DBIter, StorageHasher, DB}; use super::storage_api; +use crate::types::storage::BlockHeight; #[macro_use] mod router; @@ -47,7 +48,9 @@ where D: 'static + DB + for<'iter> DBIter<'iter> + Sync, H: 'static + StorageHasher + Sync, { - if request.height != ctx.storage.last_height { + if request.height != BlockHeight(0) + && request.height != ctx.storage.last_height + { return Err(storage_api::Error::new_const( "This query doesn't support arbitrary block heights, only the \ latest committed block height ('0' can be used as a special \ From 86ac4d2b78af831b8b87210267cdb1689e8bf76e Mon Sep 17 00:00:00 2001 From: James Hiew Date: Mon, 7 Nov 2022 18:32:11 +0000 Subject: [PATCH 2/2] Add changelog --- .../unreleased/bug-fixes/752-fix-require-latest-height.md | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 .changelog/unreleased/bug-fixes/752-fix-require-latest-height.md diff --git a/.changelog/unreleased/bug-fixes/752-fix-require-latest-height.md b/.changelog/unreleased/bug-fixes/752-fix-require-latest-height.md new file mode 100644 index 0000000000..a784de188b --- /dev/null +++ b/.changelog/unreleased/bug-fixes/752-fix-require-latest-height.md @@ -0,0 +1,2 @@ +- require_latest_height should skip requests with height 0 + ([#752](https://github.com/anoma/namada/pull/752)) \ No newline at end of file