Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid redundant wrapper signatures #3896

Closed
wants to merge 5 commits into from
Closed

Conversation

grarco
Copy link
Contributor

@grarco grarco commented Oct 7, 2024

Describe your changes

Temporary, non-breaking workaround for #3883.

Adds an SDK function to remove the duplicated wrapper signatures that might come from build_batch. Updates batch_opt_reveal_pk_and_submit to call such function.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 75.72816% with 25 lines in your changes missing coverage. Please review.

Project coverage is 73.25%. Comparing base (45e7e90) to head (b0df0e7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/lib.rs 42.30% 15 Missing ⚠️
crates/sdk/src/signing.rs 87.01% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3896   +/-   ##
=======================================
  Coverage   73.24%   73.25%           
=======================================
  Files         341      341           
  Lines      105240   105328   +88     
=======================================
+ Hits        77085    77156   +71     
- Misses      28155    28172   +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco grarco marked this pull request as ready for review October 7, 2024 11:46
@grarco grarco requested a review from tzemanovic October 7, 2024 11:47
@grarco grarco closed this Oct 8, 2024
@grarco grarco reopened this Oct 8, 2024
@grarco grarco force-pushed the grarco/avoid-redundant-sigs branch from b0df0e7 to 5c08510 Compare October 9, 2024 14:53
@grarco
Copy link
Contributor Author

grarco commented Oct 9, 2024

@tzemanovic seems like we have a failure in the speculos test, could be because of the extra function called now for the signature but I'm not sure

@tzemanovic
Copy link
Member

tzemanovic commented Oct 10, 2024

@tzemanovic seems like we have a failure in the speculos test, could be because of the extra function called now for the signature but I'm not sure

Yeah, it is that, but it's kinda odd - the first tx with bond has to be signed twice, but all the other txs (redeleg, unbonding and withdrawing) in that test have not changed.

Edit: the first tx is signed twice because of batched reveal tx, right? In the Ledger wallet it looks like it's just signing the same bond twice, maybe we can print something the client to make this clear (we have a similar UX issue in #3797).

@grarco
Copy link
Contributor Author

grarco commented Dec 1, 2024

@tzemanovic I'm closing this as in hindsight I believe it's better to pursue a cleaner solution such as #3883 (even if SDK breaking) rather than this non-breaking workaround

@grarco grarco closed this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants