-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make genesis file based on hardware wallet. #3570
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3570 +/- ##
=======================================
Coverage 54.55% 54.55%
=======================================
Files 323 323
Lines 113851 113871 +20
=======================================
+ Hits 62106 62118 +12
- Misses 51745 51753 +8 ☔ View full report in Codecov by Sentry. |
Hey @murisi, your pull request has been dequeued due to the following reason: CONFLICT_WITH_BASE_BRANCH. |
52acd7c
to
5959d7d
Compare
Describe your changes
Created an environment variable
NAMADA_E2E_USE_DEVICE
to make the end-to-end tests use the hardware wallet for all possible transaction signings. More concretely, this was done as follows:genesis/hardware
foldergenesis/localnet
to ensure the behaviour of E2E tests is not impactedequip will roof matter pink blind book anxiety banner elbow sun young
)genesis/hardware
templates if theNAMADA_E2E_USE_DEVICE
flag is set--use-device
flag if theNAMADA_E2E_USE_DEVICE
flag is setTo successfully use the
NAMADA_E2E_USE_DEVICE
environment variable, see the instructions at https://github.com/anoma/namada/blob/murisi/hw-e2e/genesis/hardware/README.md#e2e-and-integration-tests .Indicate on which release or other PRs this topic is based on
Namada v0.41.0
Checklist before merging to
draft