Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make genesis file based on hardware wallet. #3570

Merged
merged 8 commits into from
Aug 7, 2024
Merged

Make genesis file based on hardware wallet. #3570

merged 8 commits into from
Aug 7, 2024

Conversation

murisi
Copy link
Contributor

@murisi murisi commented Jul 30, 2024

Describe your changes

Created an environment variable NAMADA_E2E_USE_DEVICE to make the end-to-end tests use the hardware wallet for all possible transaction signings. More concretely, this was done as follows:

  • Generated Genesis templates based on hardware wallet keys in the genesis/hardware folder
    • These templates are identical to those in genesis/localnet to ensure the behaviour of E2E tests is not impacted
    • This generation was done with the hardware wallet configured to use the test mnemonic (equip will roof matter pink blind book anxiety banner elbow sun young)
  • Configured the E2E tests to use the genesis/hardware templates if the NAMADA_E2E_USE_DEVICE flag is set
  • Configured the E2E tests to apply the --use-device flag if the NAMADA_E2E_USE_DEVICE flag is set

To successfully use the NAMADA_E2E_USE_DEVICE environment variable, see the instructions at https://github.com/anoma/namada/blob/murisi/hw-e2e/genesis/hardware/README.md#e2e-and-integration-tests .

Indicate on which release or other PRs this topic is based on

Namada v0.41.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 48.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 54.55%. Comparing base (6d3fc90) to head (5959d7d).

Files Patch % Lines
crates/apps_lib/src/cli.rs 0.00% 11 Missing ⚠️
crates/apps_lib/src/wallet/defaults.rs 85.71% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3570   +/-   ##
=======================================
  Coverage   54.55%   54.55%           
=======================================
  Files         323      323           
  Lines      113851   113871   +20     
=======================================
+ Hits        62106    62118   +12     
- Misses      51745    51753    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@murisi murisi marked this pull request as ready for review August 5, 2024 16:16
@murisi murisi added the testing label Aug 6, 2024
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 7, 2024
Copy link
Contributor

mergify bot commented Aug 7, 2024

Hey @murisi, your pull request has been dequeued due to the following reason: CONFLICT_WITH_BASE_BRANCH.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@mergify mergify bot merged commit dd3a56f into main Aug 7, 2024
20 of 21 checks passed
@mergify mergify bot deleted the murisi/hw-e2e branch August 7, 2024 14:03
@tzemanovic tzemanovic mentioned this pull request Sep 26, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants