From 948215ea2c616c3ced4669b81e3ae7ee077437a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Zemanovi=C4=8D?= Date: Tue, 23 May 2023 17:08:52 +0200 Subject: [PATCH 1/2] client: stop waiting for catch-up when max tries are reached --- apps/src/bin/namada-client/cli.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/src/bin/namada-client/cli.rs b/apps/src/bin/namada-client/cli.rs index b33ccf87f2..95dc13f4f1 100644 --- a/apps/src/bin/namada-client/cli.rs +++ b/apps/src/bin/namada-client/cli.rs @@ -179,7 +179,7 @@ async fn wait_until_node_is_synched(ledger_address: &TendermintAddress) { if is_at_least_height_one && !is_catching_up { return; } else { - if try_count > MAX_TRIES { + if try_count == MAX_TRIES { println!( "Node is still catching up, wait for it to finish \ synching." From 939f29117b1cd926422bb59b58c6459fadd4d2f1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Zemanovi=C4=8D?= Date: Tue, 23 May 2023 17:17:18 +0200 Subject: [PATCH 2/2] changelog: #1456 --- .changelog/unreleased/bug-fixes/1456-fix-max-wait-tries.md | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 .changelog/unreleased/bug-fixes/1456-fix-max-wait-tries.md diff --git a/.changelog/unreleased/bug-fixes/1456-fix-max-wait-tries.md b/.changelog/unreleased/bug-fixes/1456-fix-max-wait-tries.md new file mode 100644 index 0000000000..fdf18ff5ec --- /dev/null +++ b/.changelog/unreleased/bug-fixes/1456-fix-max-wait-tries.md @@ -0,0 +1,2 @@ +- Client: Fixed an off-by-one error to stop waiting for start or catch-up when + max tries are reached. ([\#1456](https://github.com/anoma/namada/pull/1456)) \ No newline at end of file