Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generalize SignedTxData to allow multiple signatures #85

Closed
tzemanovic opened this issue Mar 3, 2022 · 4 comments
Closed

generalize SignedTxData to allow multiple signatures #85

tzemanovic opened this issue Mar 3, 2022 · 4 comments
Assignees
Labels

Comments

@tzemanovic
Copy link
Member

This is to allow transactions with multiple signatures (e.g. multi-sig VP or multiple transfers from different sources bundled in one tx).

A possible approach would be to replace the sig field with e.g.

pub struct SignedTxData {
    ...
    /// The signatures are produced on the unsigned tx (tx data concatenated
    /// with the tx code and the timestamp).
    pub sigs: BTreeMap<PublicKeyHash, common::Signature>,
}

So a VP looking for a signature can look it up from the sigs using the hash of its PK.

@cwgoes
Copy link
Collaborator

cwgoes commented Mar 14, 2022

We should figure out a good generalised way to encode arbitrary VP-required data, provided by intents, in transactions - for example, we could have transactions include a VP-address-indexed map of byte arrays (which can then be encoded in a way understood by the validity predicate, e.g. as a set of signatures).

@cwgoes
Copy link
Collaborator

cwgoes commented Jan 12, 2023

@grarco what is the status of this w.r.t. the multisignature VP?

@grarco
Copy link
Collaborator

grarco commented Jan 12, 2023

We started addressing this with the specs of #680. Should we close this in favor of #81 since they look very similar?

@grarco
Copy link
Collaborator

grarco commented Jan 14, 2023

Close in favor of #81

@grarco grarco closed this as completed Jan 14, 2023
@github-project-automation github-project-automation bot moved this from Todo to Tested in Devnet in Namada-Old Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Tested in Devnet
Development

No branches or pull requests

3 participants