Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoS VP init-validator validation returns too early #762

Closed
tzemanovic opened this issue Nov 9, 2022 · 0 comments · Fixed by #763
Closed

PoS VP init-validator validation returns too early #762

tzemanovic opened this issue Nov 9, 2022 · 0 comments · Fixed by #763
Assignees
Labels
bug Something isn't working PoS validity-predicate

Comments

@tzemanovic
Copy link
Member

When we simplified our protocol rule regarding storage keys and how they're passed to VPs, an update in PoS VP https://github.com/anoma/anoma/pull/998/files#diff-74ae34f077487e3de4912f1195b3911b37d8ed6beb11f9d27e9b65470498df4dR284 accidentally introduced a bug. The VP shouldn't return early when an unknown permitted key is encountered - it must continue to validate the rest of the keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PoS validity-predicate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant