Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomize storage.address_gen with the chain ID #6

Closed
tzemanovic opened this issue May 7, 2021 · 2 comments · Fixed by #2088
Closed

Randomize storage.address_gen with the chain ID #6

tzemanovic opened this issue May 7, 2021 · 2 comments · Fixed by #2088
Assignees
Labels
good first issue Good for newcomers ledger

Comments

@tzemanovic
Copy link
Member

tzemanovic commented May 7, 2021

we should add the chain id to have unique address on different chains

Originally posted by tzemanovic in anoma/anoma#175 (comment)

┆Issue is synchronized with this Asana task by Unito

@cwgoes
Copy link
Collaborator

cwgoes commented Jan 12, 2023

Hmm, I'm not sure we want to do it this way, since we might change the chain ID of a running chain (with an upgrade) and we don't want the address format to change. Closing for now, but reopen if there's another reason which I didn't consider.

@cwgoes cwgoes closed this as completed Jan 12, 2023
@github-project-automation github-project-automation bot moved this from Todo to Tested in Devnet in Namada-Old Jan 12, 2023
@tzemanovic
Copy link
Member Author

Hmm, I'm not sure we want to do it this way, since we might change the chain ID of a running chain (with an upgrade) and we don't want the address format to change. Closing for now, but reopen if there's another reason which I didn't consider.

ah sry, the issue's description isn't very clear - what I meant is to add the chain ID to the initial seed for on-chain generated addresses - I have something like this implemented in #685 (WIP), where the seed starts from the genesis bytes. A change of chain ID won't affect format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ledger
Projects
No open projects
Status: Tested in Devnet
4 participants