Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rust_decimal instead of f64 to perform token conversions and calculations #435

Closed
brentstone opened this issue Sep 5, 2022 · 0 comments · Fixed by #436
Closed

Use rust_decimal instead of f64 to perform token conversions and calculations #435

brentstone opened this issue Sep 5, 2022 · 0 comments · Fixed by #436
Assignees
@brentstone
Labels
enhancement New feature or request PoS

Comments

@brentstone
Copy link
Collaborator

The rust_decimal crate is safer for avoiding round-off errors that can result from some imprecision with floats. This crate is also starting to be used elsewhere in proof-of-stake. We should phase out the use of floats in the code altogether.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brentstone brentstone

Labels
enhancement New feature or request PoS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace f64 with rust_decimal in token conversions anoma/namada
1 participant
@brentstone