Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override the ICS-20 base denom of NAM in CLI #4060

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Nov 20, 2024

Describe your changes

The base denom in IBC token should be taken in as is

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@yito88 yito88 requested review from tzemanovic and sug0 November 20, 2024 21:21
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.32%. Comparing base (dc0904f) to head (016bf1f).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4060      +/-   ##
==========================================
- Coverage   74.34%   74.32%   -0.02%     
==========================================
  Files         341      341              
  Lines      107273   107401     +128     
==========================================
+ Hits        79748    79827      +79     
- Misses      27525    27574      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@brentstone
Copy link
Collaborator

@yito88 does this still permit the usage of an alias in the wallet for a token address, like nam as is default in everyone's wallet and uosmo as I was using in the examples on our internal Slack?

@yito88
Copy link
Member Author

yito88 commented Nov 21, 2024

@brentstone Yes, we can use these aliases; nam and other foreign tokens.

@sug0 sug0 changed the title Use base token of IBC token as it is Override the ICS-20 base denom of NAM in CLI Nov 21, 2024
@sug0
Copy link
Collaborator

sug0 commented Nov 21, 2024

Changed the title of the PR to something more accurate

@sug0 sug0 added breaking:cli merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass labels Nov 21, 2024
@mergify mergify bot merged commit 6c5c61b into main Nov 21, 2024
23 of 24 checks passed
@mergify mergify bot deleted the yuji/fix-parsing-ibc-denom branch November 21, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking:cli merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants