Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change votes per token PoS param to be per smallest denomination #391

Closed
tzemanovic opened this issue Aug 29, 2022 · 2 comments
Closed

change votes per token PoS param to be per smallest denomination #391

tzemanovic opened this issue Aug 29, 2022 · 2 comments
Labels

Comments

@tzemanovic
Copy link
Member

depends on #386

In genesis, we want to configure the votes_per_token to be 1/100 vote per namnam. Currently, it's calculated from whole tokens, so we want to change to be able express votes per nano tokens (in parts-per-billion instead of basis points).

Note that our total staked whole tokens will be capped at around i64::MAX / 8 / 10^7 = 115_292_150_460 (tendermint total voting power has upper limit of i64::MAX / 8) (related issue #159)

@brentstone
Copy link
Collaborator

brentstone commented Sep 4, 2022

I'm wondering if we may have an issue in the above case by storing namnam as a u64. If the maximum whole staked tokens is capped at 115_292_150_460, then let's say the max namnam is 115_292_150_460_000_000_000, but this is about 6.25 times the value of u64::MAX. Perhaps an easy fix could be to increase the votes_per_token.

@tzemanovic
Copy link
Member Author

closing as #386 not gonna be implemented

@tzemanovic tzemanovic closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2022
Repository owner moved this from Todo to Tested in Devnet in Namada-Old Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Tested in Devnet
Development

Successfully merging a pull request may close this issue.

2 participants