Adjust IBC e2e test config #3455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yito88
commented
Jun 28, 2024
crates/tests/src/e2e/helpers.rs
Outdated
| @@ -537,7 +537,7 @@ pub fn make_hermes_config(test_a: &Test, test_b: &Test) -> Result<()> { | |||
|
|
|||
| let mut packets = toml::map::Map::new(); | |||
| packets.insert("enabled".to_owned(), Value::Boolean(true)); | |||
| packets.insert("clear_interval".to_owned(), Value::Integer(10)); | |||
| packets.insert("clear_interval".to_owned(), Value::Integer(20)); | |||
There was a problem hiding this comment.
Avoid terminating the packet-clearing thread in Hermes
yito88
commented
Jun 28, 2024
| @@ -614,12 +614,14 @@ fn make_hermes_chain_config(test: &Test) -> Value { | |||
| ); | |||
| chain.insert("store_prefix".to_owned(), Value::String("ibc".to_owned())); | |||
| let mut table = toml::map::Map::new(); | |||
| table.insert("price".to_owned(), Value::Float(0.001)); | |||
| table.insert("price".to_owned(), Value::Float(0.000001)); | |||
There was a problem hiding this comment.
Set the practical gas price for the gas estimation feature in Hermes
yito88
commented
Jun 28, 2024
| std::env::set_var(ENV_VAR_CHAIN_ID, test.net.chain_id.to_string()); | ||
| let nam_addr = find_address(test, setup::constants::NAM).unwrap(); | ||
| table.insert("denom".to_owned(), Value::String(nam_addr.to_string())); | ||
| chain.insert("gas_price".to_owned(), Value::Table(table)); | ||
|
|
||
| chain.insert("max_block_time".to_owned(), Value::String("60s".to_owned())); |
There was a problem hiding this comment.
To retry in the longer time
yito88
commented
Jun 28, 2024
| @@ -955,7 +955,7 @@ fn create_channel_with_hermes( | |||
| "--yes", | |||
| ]; | |||
|
|
|||
| let mut hermes = run_hermes_cmd(test_a, args, Some(120))?; | |||
| let mut hermes = run_hermes_cmd(test_a, args, Some(240))?; | |||
There was a problem hiding this comment.
Avoid timeout for the channel creation handshake
yito88
commented
Jun 28, 2024
| "e2e::ibc_tests::pgf_over_ibc_with_hermes": 810, | ||
| "e2e::ibc_tests::proposal_ibc_token_inflation": 1100, | ||
| "e2e::ibc_tests::ibc_rate_limit": 430, | ||
| "e2e::ibc_tests::ibc_namada_gaia": 180, |
There was a problem hiding this comment.
some tests were changed. Set the latest actual time in CI.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3455 +/- ##
==========================================
- Coverage 53.92% 53.92% -0.01%
==========================================
Files 317 317
Lines 107575 107575
==========================================
- Hits 58011 58005 -6
- Misses 49564 49570 +6 ☔ View full report in Codecov by Sentry. |
yito88
force-pushed
the
yuji/ibc-e2e-config
branch
from
dcfe259 to
52adb35
Compare
brentstone
added a commit
that referenced
this pull request
Jul 2, 2024
* yuji/ibc-e2e-config: longer interval add changelog clear on start change IBC e2e test config
brentstone
added a commit
that referenced
this pull request
Jul 2, 2024
* yuji/ibc-e2e-config: longer interval add changelog clear on start change IBC e2e test config
brentstone
added a commit
that referenced
this pull request
Jul 2, 2024
* yuji/ibc-e2e-config: longer interval add changelog clear on start change IBC e2e test config
brentstone
approved these changes
Jul 3, 2024
brentstone
added a commit
that referenced
this pull request
Jul 3, 2024
* yuji/ibc-e2e-config: longer interval add changelog clear on start change IBC e2e test config
Closed
brentstone
added a commit
that referenced
this pull request
Jul 4, 2024
* origin/yuji/ibc-e2e-config: longer interval add changelog clear on start change IBC e2e test config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
IBC E2E tests are getting flaky. It seems that the load for running two nodes is increasing and the IBC process sometimes is delayed.
Indicate on which release or other PRs this topic is based on
v0.39.0Checklist before merging to
draft