-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring rocksdb.rs #2938
Refactoring rocksdb.rs #2938
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2938 +/- ##
========================================
Coverage 59.39% 59.40%
========================================
Files 298 298
Lines 92771 92478 -293
========================================
- Hits 55104 54934 -170
+ Misses 37667 37544 -123 ☔ View full report in Codecov by Sentry. |
2b1b87a
to
e68f74b
Compare
do u think we could also upgrade rocksdb dependency to 0.22.0? I started doing this is another PR but it was closed due to some other reasons. You can take a look here |
e68f74b
to
f5ed1c3
Compare
is this ready? |
* yuji/refactoring-rocksdb: add changelog fix after rebasing for dump and rollback refactor mockdb always use batch write WIP: refactor add_block_to_batch simplify read_last_block
* yuji/refactoring-rocksdb: add changelog fix after rebasing for dump and rollback refactor mockdb always use batch write WIP: refactor add_block_to_batch simplify read_last_block
Describe your changes
read_last_block
read_last_block
in many caseswrite_subspace_val
anddelete_subspace_val
Indicate on which release or other PRs this topic is based on
v0.33.0
Checklist before merging to
draft