Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All uses of Epoched past epoch tracking and handling of last_update may not be consistent #2665

Closed
Tracked by #2530
brentstone opened this issue Feb 20, 2024 · 0 comments · Fixed by #2667
Closed
Tracked by #2530
Assignees
Labels
bug Something isn't working PoS

Comments

@brentstone
Copy link
Collaborator

A storage dump from epoch 8 at height 35201 had the following storage ket structure for a validator:

"#tnam1qgqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqc8j2fp/validator/#tnam1q96tsxckvm4n937efh7t78w4j40m5783wsqcz3ye/state/last_update" = "0900000000000000"
"#tnam1qgqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqc8j2fp/validator/#tnam1q96tsxckvm4n937efh7t78w4j40m5783wsqcz3ye/state/lazy_map/data/000000000000E" = "00"
"#tnam1qgqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqc8j2fp/validator/#tnam1q96tsxckvm4n937efh7t78w4j40m5783wsqcz3ye/state/lazy_map/data/000000000000G" = "01"
"#tnam1qgqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqc8j2fp/validator/#tnam1q96tsxckvm4n937efh7t78w4j40m5783wsqcz3ye/state/lazy_map/data/000000000000I" = "00"
"#tnam1qgqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqc8j2fp/validator/#tnam1q96tsxckvm4n937efh7t78w4j40m5783wsqcz3ye/state/oldest_epoch" = "0700000000000000"

I would not have expected last_update = 9 and would've expected at least one more epoch in the past stored, since pipeline_len epochs should be kept in the past for the ValidatorStates. It is possible that function calls that manipulate this data may not be performed consistently.

Check that all these operations are consistent. Furthermore, recheck that the NestedEpoched objects like the validator sets and positions and addresses are storing what is expected.

@brentstone brentstone added the PoS label Feb 20, 2024
@tzemanovic tzemanovic added the bug Something isn't working label Feb 26, 2024
@brentstone brentstone added this to the Phase 1: mainnet genesis milestone Apr 6, 2024
@brentstone brentstone self-assigned this Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PoS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants