Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only use the first address of a storage key to invoke VP #2629

Closed
Tracked by #2841 ...
cwgoes opened this issue Feb 15, 2024 · 2 comments · Fixed by #2934
Closed
Tracked by #2841 ...

only use the first address of a storage key to invoke VP #2629

cwgoes opened this issue Feb 15, 2024 · 2 comments · Fixed by #2934
Assignees
Labels
pre-mainnet Must happen before mainnet. security

Comments

@cwgoes
Copy link
Collaborator

cwgoes commented Feb 15, 2024

This may be an issue w/the execution model.

@cwgoes cwgoes added the pre-mainnet Must happen before mainnet. label Feb 15, 2024
@cwgoes
Copy link
Collaborator Author

cwgoes commented Feb 16, 2024

We should remove the logic which parses all addresses for a key, and replace it with explicit inclusion in the verifiers list (and only parse the first address).

@tzemanovic tzemanovic changed the title Investigate why other validator VPs are being called only use the first address of a storage key to invoke VP Mar 7, 2024
@cwgoes
Copy link
Collaborator Author

cwgoes commented Mar 19, 2024

With this change:

  • we will need to manually trigger other VPs in whatever VP should be triggering them (e.g. multitoken, proof-of-stake)
  • we will need to rework vp_user to perform only signature validation, and move proof-of-stake etc. validation logic to the respective VPs

@tzemanovic will take this on; @batconjurer will review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-mainnet Must happen before mainnet. security
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants