Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit for all uses of HashSet in the codebase #2576

Closed
Tracked by #2531
cwgoes opened this issue Feb 9, 2024 · 0 comments · Fixed by #2685
Closed
Tracked by #2531

Audit for all uses of HashSet in the codebase #2576

cwgoes opened this issue Feb 9, 2024 · 0 comments · Fixed by #2685
Assignees
@sug0
Labels
has-a-pr The issue has been solved by a PR that has yet to be merged pre-mainnet Must happen before mainnet. security
Milestone
Phase 1: mainnet ...

Comments

@cwgoes
Copy link
Collaborator

cwgoes commented Feb 9, 2024 •
edited by tzemanovic
Loading

Iteration over HashSet/Map in state machine code is non-deterministic and strictly prohibited.
@cwgoes cwgoes added the security label Feb 9, 2024
@cwgoes cwgoes mentioned this issue Feb 9, 2024
Closed
13 tasks
@cwgoes cwgoes added the pre-mainnet Must happen before mainnet. label Feb 9, 2024
@sug0 sug0 self-assigned this Feb 19, 2024
@cwgoes cwgoes mentioned this issue Feb 20, 2024
Closed
@sug0 sug0 mentioned this issue Feb 21, 2024
Merged
2 tasks
@tzemanovic tzemanovic mentioned this issue Feb 22, 2024
Closed
@cwgoes cwgoes mentioned this issue Mar 4, 2024
Closed
10 tasks
@sug0 sug0 added the has-a-pr The issue has been solved by a PR that has yet to be merged label Mar 4, 2024
@brentstone brentstone added this to the Phase 1: mainnet genesis milestone Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sug0 sug0

Labels
has-a-pr The issue has been solved by a PR that has yet to be merged pre-mainnet Must happen before mainnet. security
Projects
None yet
Milestone
Phase 1: mainnet genesis
Development

Successfully merging a pull request may close this issue.

Replace hash maps and sets with indexmap equivalents anoma/namada
3 participants
@sug0 @cwgoes @brentstone