Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace borsh fork with upstream version #1895

Closed
sug0 opened this issue Sep 15, 2023 · 2 comments · Fixed by #1930
Closed

Replace borsh fork with upstream version #1895

sug0 opened this issue Sep 15, 2023 · 2 comments · Fixed by #1930
Labels
duplicate This issue or pull request already exists enhancement New feature or request SDK

Comments

@sug0
Copy link
Collaborator

sug0 commented Sep 15, 2023 •
edited
Loading

Since May of 2023, all patches in our fork of borsh have been upstreamed. We should switch to the upstream version, as this brings several advantages, including an improved usability of the Namada SDK, since users won't need to patch borsh in their Cargo files.
@sug0 sug0 added the enhancement New feature or request label Sep 15, 2023
@sug0
Copy link
Collaborator Author

sug0 commented Sep 15, 2023 •
edited
Loading

As of the 16th of September of 2023, the most up to date version is 1.0.0-alpha.4. An effort to switch to upstream borsh has been started in tiago/update-borsh.

@sug0 sug0 added the SDK label Sep 15, 2023
@sug0
Copy link
Collaborator Author

sug0 commented Sep 15, 2023

Duplicate of #1563

@sug0 sug0 added the duplicate This issue or pull request already exists label Sep 15, 2023
@sug0 sug0 mentioned this issue Sep 25, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists enhancement New feature or request SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to upstream borsh 1.0.0 (alpha 4) anoma/namada
1 participant
@sug0